Removing implicitmsal (#485)

Author: nikithauc

authProviderOptions/es/msal/index.ts

@@ -0,0 +1,4 @@
+.npmignore
+test/
+**/*.tsbuildinfo
+es/test/

authProviderOptions/msal/index.ts

@@ -104,7 +104,6 @@
 		"karma-typescript": "^5.2.0",
 		"lint-staged": "^11.0.0",
 		"mocha": "^6.2.3",
-		"msal": "^1.0.0",
 		"nyc": "^15.1.0",
 		"prettier": "^1.17.0",
 		"rollup": "^2.36.2",
@@ -123,9 +122,6 @@
 		"buffer": {
 			"optional": true
 		},
-		"msal": {
-			"optional": true
-		},
 		"stream-browserify": {
 			"optional": true
 		},

docs/ImplicitMSALAuthenticationProvider.md

@@ -19,7 +19,7 @@ const copyRight = `/**
 
 const config = [
 	{
-		input: ["lib/es/src/browser/rollupEntry.js"],
+		input: ["lib/es/src/browser/index.js"],
 		output: {
 			file: "lib/graph-js-sdk.js",
 			format: "iife",

lib/.npmignore

@@ -13,36 +13,8 @@ import { AccountInfo, InteractionType } from "@azure/msal-browser";
 
 import { AuthenticationProviderOptions } from "../../IAuthenticationProviderOptions";
 
-/**
- * @deprecated
- * @class
- * @implements AuthenticationProviderOptions
- * Class representing MSALAuthenticationProviderOptions
- */
-export class MSALAuthenticationProviderOptions implements AuthenticationProviderOptions {
-	/**
-	 * @public
-	 * A member holding array of scopes
-	 */
-	public scopes: string[];
-
-	/**
-	 * @public
-	 * @constructor
-	 * To create an instance of MSALAuthenticationProviderOptions
-	 * @param {string[]} scopes - An array of scopes
-	 * @returns An instance of MSALAuthenticationProviderOptions
-	 */
-	public constructor(scopes: string[]) {
-		this.scopes = scopes;
-	}
-}
-
-export interface MSALAuthenticationProviderSharedOptions extends AuthenticationProviderOptions {
+export interface AuthCodeMSALBrowserAuthenticationProviderOptions extends AuthenticationProviderOptions {
 	scopes: string[];
-}
-
-export interface AuthCodeMSALBrowserAuthenticationProviderOptions extends MSALAuthenticationProviderSharedOptions {
 	account: AccountInfo;
 	interactionType: InteractionType;
 }

package.json

@@ -7,22 +7,21 @@
 
 import { assert } from "chai";
 
-import { MSALAuthenticationProviderOptions } from "../../../src/authentication/msalOptions/MSALAuthenticationProviderOptions";
 import { AuthenticationHandlerOptions } from "../../../src/middleware/options/AuthenticationHandlerOptions";
 import { DummyAuthenticationProvider } from "../../DummyAuthenticationProvider";
 
 describe("AuthenticationHandlerOptions.ts", () => {
 	const dummyAuthProvider = new DummyAuthenticationProvider();
-	const msalAuthProviderOptions = new MSALAuthenticationProviderOptions([]);
+	const authOptions = { scopes: ["test"] };
 	it("Should create an instance with all the given options", () => {
-		const options = new AuthenticationHandlerOptions(dummyAuthProvider, msalAuthProviderOptions);
+		const options = new AuthenticationHandlerOptions(dummyAuthProvider, authOptions);
 		assert.equal(options.authenticationProvider, dummyAuthProvider);
-		assert.equal(options.authenticationProviderOptions, msalAuthProviderOptions);
+		assert.equal(options.authenticationProviderOptions, authOptions);
 	});
 
 	it("Should be undefined value if no value is passed", () => {
-		const options = new AuthenticationHandlerOptions(undefined, msalAuthProviderOptions);
+		const options = new AuthenticationHandlerOptions(undefined, authOptions);
 		assert.isUndefined(options.authenticationProvider);
-		assert.equal(options.authenticationProviderOptions, msalAuthProviderOptions);
+		assert.equal(options.authenticationProviderOptions, authOptions);
 	});
 });