You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Since Redis has been forked to Valkey and many projects are likely to adopt Valkey over Redis, using RedisManager/AsyncRedisManager no longer works with Valkey URLs (e.g., valkey://...) and valkey-py, as it only checks for Redis URLs (e.g., redis://...).
Solution
I created a custom implementation called ValkeyManager/AsyncValkeyManager inherited from PubSubManager/AsyncPubSubManager, using valkey-py instead of redis-py.
Why This Matters
Due to Redis' licensing change, many projects are transitioning to Valkey. Adding support for Valkey URLs would help users migrate seamlessly and avoid the need for custom solutions.
Request
Would it be possible to integrate support for Valkey URLs in the official implementation? This would make it easier for projects to adopt Valkey.
The text was updated successfully, but these errors were encountered:
Ohnoimded
changed the title
Support for Valkey based client manager
Support for valkey-py based client manager
Dec 27, 2024
Instead of duplicating the existing classes that work with Redis, I would prefer to extend them to support either the Redis or the Valkey clients. This would avoid code duplication, at least while the two projects mantain similar APIs.
Problem
Since Redis has been forked to Valkey and many projects are likely to adopt Valkey over Redis, using RedisManager/AsyncRedisManager no longer works with Valkey URLs (e.g.,
valkey://...
) and valkey-py, as it only checks for Redis URLs (e.g.,redis://...
).Solution
I created a custom implementation called
ValkeyManager/AsyncValkeyManager
inherited fromPubSubManager/AsyncPubSubManager
, using valkey-py instead of redis-py.Why This Matters
Due to Redis' licensing change, many projects are transitioning to Valkey. Adding support for Valkey URLs would help users migrate seamlessly and avoid the need for custom solutions.
Request
Would it be possible to integrate support for Valkey URLs in the official implementation? This would make it easier for projects to adopt Valkey.
The text was updated successfully, but these errors were encountered: