fix(ci): guard auth gate package-mode builds#2157
Closed
NubsCarson wants to merge 1 commit into
Closed
Conversation
This was referenced May 19, 2026
ApprovabilityVerdict: Needs human review Unable to check for correctness in 5f777b4. You can customize Macroscope's approvability policy. Learn more. |
Contributor
|
Credit balance is too low |
Contributor
Author
|
Closing this standalone guard PR to avoid PR noise. The guard itself is still valid, but this branch cannot independently pass current package-mode CI from bare develop because the UI/package-mode fixes in #2153 are also required (typecheck fails on missing @elizaos/ui exports before this guard matters). The same Auth P0 guard remains included in #2153, where it is paired with the package-mode fixes that make the branch buildable. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds a small guard to the agent-review Auth P0 workflow so package-mode PR checkouts skip the local Eliza runtime plugin build when the nested
eliza/packages/corecheckout is absent.Why
Several package-mode Milady PRs can fail before their actual auth tests because the
pull_request_targetworkflow assumeseliza/packages/coreexists and then runs:(cd eliza/packages/core && bun run build)That directory is only present in local-source/nested-Eliza checkouts. In package-mode checkouts the workflow should skip this optional local runtime plugin prebuild instead of failing with
cd: eliza/packages/core: No such file or directory.This is intentionally split from the larger Android APK/runtime PR so maintainers can land the base workflow fix independently.
Validation
Both passed locally.
Notes
Because this workflow runs under
pull_request_target, GitHub evaluates the workflow file from the base branch. This PR may not be able to make its own Auth P0 run observe the guard until the change lands ondevelop; the value here is unblocking subsequent PR checks once merged.Note
Skip local eliza runtime plugin build when
eliza/packages/coreis absentAdds a directory existence check at the start of the 'Build local eliza runtime plugins' step in agent-review.yml. If
eliza/packages/coreis missing, the step prints a message and exits successfully instead of running build commands that would fail.Macroscope summarized 5f777b4.