Skip to content

fix(ci): guard auth gate package-mode builds#2157

Closed
NubsCarson wants to merge 1 commit into
developfrom
codex/auth-p0-package-mode-guard-20260519
Closed

fix(ci): guard auth gate package-mode builds#2157
NubsCarson wants to merge 1 commit into
developfrom
codex/auth-p0-package-mode-guard-20260519

Conversation

@NubsCarson
Copy link
Copy Markdown
Contributor

@NubsCarson NubsCarson commented May 19, 2026

Summary

Adds a small guard to the agent-review Auth P0 workflow so package-mode PR checkouts skip the local Eliza runtime plugin build when the nested eliza/packages/core checkout is absent.

Why

Several package-mode Milady PRs can fail before their actual auth tests because the pull_request_target workflow assumes eliza/packages/core exists and then runs:

(cd eliza/packages/core && bun run build)

That directory is only present in local-source/nested-Eliza checkouts. In package-mode checkouts the workflow should skip this optional local runtime plugin prebuild instead of failing with cd: eliza/packages/core: No such file or directory.

This is intentionally split from the larger Android APK/runtime PR so maintainers can land the base workflow fix independently.

Validation

git diff --check
node scripts/validate-ci-bootstrap-contract.mjs

Both passed locally.

Notes

Because this workflow runs under pull_request_target, GitHub evaluates the workflow file from the base branch. This PR may not be able to make its own Auth P0 run observe the guard until the change lands on develop; the value here is unblocking subsequent PR checks once merged.

Note

Skip local eliza runtime plugin build when eliza/packages/core is absent

Adds a directory existence check at the start of the 'Build local eliza runtime plugins' step in agent-review.yml. If eliza/packages/core is missing, the step prints a message and exits successfully instead of running build commands that would fail.

Macroscope summarized 5f777b4.

@macroscopeapp
Copy link
Copy Markdown

macroscopeapp Bot commented May 19, 2026

Approvability

Verdict: Needs human review

Unable to check for correctness in 5f777b4.

You can customize Macroscope's approvability policy. Learn more.

@github-actions
Copy link
Copy Markdown
Contributor

Credit balance is too low

@github-actions github-actions Bot added category:ci Auto-managed semantic PR category trust:probationary Building trust, closer scrutiny (auto-managed) labels May 19, 2026
@NubsCarson
Copy link
Copy Markdown
Contributor Author

Closing this standalone guard PR to avoid PR noise. The guard itself is still valid, but this branch cannot independently pass current package-mode CI from bare develop because the UI/package-mode fixes in #2153 are also required (typecheck fails on missing @elizaos/ui exports before this guard matters). The same Auth P0 guard remains included in #2153, where it is paired with the package-mode fixes that make the branch buildable.

@NubsCarson NubsCarson closed this May 19, 2026
@NubsCarson NubsCarson deleted the codex/auth-p0-package-mode-guard-20260519 branch May 19, 2026 03:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

category:ci Auto-managed semantic PR category trust:probationary Building trust, closer scrutiny (auto-managed)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant