fix(ci): guard package-mode workflows#2158
Conversation
ApprovabilityVerdict: Needs human review Unable to check for correctness in 79312f9. You can customize Macroscope's approvability policy. Learn more. |
|
Credit balance is too low |
|
Credit balance is too low |
|
Credit balance is too low |
# Conflicts: # scripts/validate-ci-bootstrap-contract.mjs
|
Credit balance is too low |
|
Credit balance is too low |
… into nubs/fix-agent-review-package-mode
|
Stack follow-up, 2026-05-19: merged #2153 |
|
Credit balance is too low |
… into nubs/fix-agent-review-package-mode
|
Credit balance is too low |
|
Credit balance is too low |
|
Final stack refresh, 2026-05-19: latest head |
… into nubs/fix-agent-review-package-mode
|
Update 2026-05-19: refreshed this stack onto #2153 head |
|
Credit balance is too low |
|
Status refresh (2026-05-19):
No new source changes pushed to this PR in this refresh; this comment is only a status/maintainer-context update. |
Summary
Fixes two CI contract breaks that affect package-mode Milady PRs:
eliza/checkout exists and fails package-mode PRs atcd eliza/packages/core.Changes
Build local eliza runtime pluginswithhashFiles('eliza/package.json') != '', matching the existing package-mode guard pattern used by CI jobs.scripts/ci-bootstrap-contract.test.tsso the Auth P0 workflow contract requires that guard.scripts/validate-ci-bootstrap-contract.mjsso the standalone CI contract validator also prevents regressing this workflow..github/workflows/release-electrobun.yml:ggml-base.en.binonce invalidate-release,whisper-model-base-en,validate-releaseran.ensure-whisper-model.shinstead of the olderwhisper-nodepackage-local model copier.Validation
Ran in an isolated worktree based on current
develop:Results:
ci-bootstrap-contract.test.ts: 8 tests passed.validate-ci-bootstrap-contract.mjs: passed.test:release:contract: local wrapper contract passed; local Eliza checkout was absent, so the nested release-check portion was skipped locally exactly as the script reports.Stack Status
Updated 2026-05-19 after #2153 moved to
85335e9cb: merged the new #2153 head into this stack with no manual conflicts. Local verification onb2ce6af0d:bunx vitest run scripts/ci-bootstrap-contract.test.ts scripts/release-workflow-contract.test.mjs apps/app/test/package-mode-aliases.test.tspassed with 46 passed / 1 skipped,node scripts/validate-ci-bootstrap-contract.mjspassed, Biome passed on touched workflow/app contract files,git diff --checkpassed, andbun run test:release:contractpassed with the expected local-eliza/release-check skip. The PR remains draft because merge order is still #2153 first, then this workflow guard follow-up.Current stacked diff against #2153 is intentionally narrow:
.github/workflows/release-electrobun.ymlscripts/apply-eliza-ci-patches.mjsscripts/ci-bootstrap-contract.test.tsscripts/release-workflow-contract.test.mjsPull Request Target Limitation
After stacking this PR on #2153, the
Auth tests (P0 gate)check still fails before running auth tests. The new failing run confirms GitHub is executing thepull_request_targetworkflow YAML from currentdevelop, not the PR head or stacked base branch. The log still runs the unguardedBuild local eliza runtime pluginsstep and dies atcd eliza/packages/corein package-mode checkout.That means this PR can validate the workflow contract statically and through normal CI, but the Auth P0 gate itself cannot turn green until the guard exists on
develop. Keeping this PR draft is intentional until maintainers decide whether to merge the guard through #2153 / this stack or apply it directly todevelop.GitHub Status After Stack
GitHub Actions on the previous stacked head had the normal package-mode CI lanes green; only Agent Review/Auth checks ran on refreshed draft head
b2ce6af0d:All Tests Passed: successLint & Format: successType Check: successUnit Tests: successBuild: successRelease Workflow Contract: successThe remaining red checks are
Auth tests (P0 gate)and its aggregateAgent Review Verdict, both caused bypull_request_targetusing the unguarded workflow from currentdevelop. The failure log dies before auth tests atcd eliza/packages/corein package-mode checkout.CI Notes
Auth tests (P0 gate)can still fail on this PR until the workflow guard lands ondevelop, because that job usespull_request_target; GitHub runs the workflow YAML from basedevelop, not this PR branch. The failing log confirms it executes the unguarded base workflow and dies atcd eliza/packages/core.The broader package-mode app lint/typecheck/build failures on this standalone workflow branch are the existing package-mode app surface fixed in #2153. This PR intentionally keeps that separate and focuses on shared CI/workflow contracts.
Impact
Once merged to
develop, this should unblock the shared Agent Review/Auth P0 failure currently visible on unrelated open PRs such as #2152, #2153, and #2155. It also keeps the Electrobun release workflow aligned with Eliza's current Whisper model artifact contract, without changing runtime app code.Note
Guard 'Build local eliza runtime plugins' step and add Whisper model caching to Electrobun release workflow
hashFiles('eliza/package.json') != ''condition to the 'Build local eliza runtime plugins' step in agent-review.yml so it is skipped when the eliza submodule is not checked out.whisper-model-base-enartifact and restoring it into$HOME/.cache/eliza/whisper/.ensure-whisper-model.shscript in apply-eliza-ci-patches.mjs to download models directly viacurl/wgetinto a user cache dir, removing the dependency onwhisper-nodepackage paths andwhisper.cpphelper scripts.Macroscope summarized 79312f9. (Automatic summaries will resume when PR exits draft mode or review begins).