Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove usage of OpenStruct or add ostruct as dependency #1116

Open
Earlopain opened this issue May 13, 2024 · 1 comment
Open

Remove usage of OpenStruct or add ostruct as dependency #1116

Earlopain opened this issue May 13, 2024 · 1 comment

Comments

@Earlopain
Copy link

Issue description

Hey there, I saw #1110 which added a require of ostruct to work around an error.

ostruct is on its way to be a bundled gem and Ruby 3.4 will warn if it is required without being specified as a dependency. ruby/ruby#10428

So I suggest removing the usage to avoid breaking in Ruby 3.5. Adding it to the gemspec is also a solution.
@joshRpowell
Copy link

agree. jbuilder removed ostruct https://github.com/rails/jbuilder/pull/567/files

@RemoteCTO RemoteCTO mentioned this issue Nov 10, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@joshRpowell @Earlopain