Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

assets: improve compatibility with Shakapacker 8 #1134

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

kemenaran
Copy link

Make the following methods work with Shakapacker 8 (instead of raising an exception):

  • running_in_development?
  • wicked_pdf_stylesheet_pack_tag
  • wicked_pdf_javascript_pack_tag
  • wicked_pdf_asset_path

Fix #1133

Make the following methods work with Shakapacker:
- `running_in_development?`
- `wicked_pdf_stylesheet_pack_tag`
- `wicked_pdf_javascript_pack_tag`
- `wicked_pdf_asset_path`
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Exception in WickedPdfHelper#running_in_development? when using Shakapacker 8
1 participant