Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

待修复的2个关键点 #16

Open
suifengwuhen opened this issue Mar 11, 2025 · 0 comments
Open

待修复的2个关键点 #16

suifengwuhen opened this issue Mar 11, 2025 · 0 comments
Labels
will_fix we got your idea ,we will fix

Comments

@suifengwuhen
Copy link

1、gitlab_integration/webhook_listener.py里面def handle_merge_request(self, gitlab_payload, reply):方法if判断加上reopen的判断

def handle_merge_request(self, gitlab_payload, reply):
        """
        处理合并请求事件
        """
        if gitlab_payload.get("object_attributes").get("state") == "opened" and (gitlab_payload.get("object_attributes").get("merge_status") == "preparing"or gitlab_payload.get("object_attributes").get("merge_status") == "can_be_merged"):

2、review_engine/handler/default_handler.py里面review_results要过滤null

def process_change(change):
            result = generate_review(change,  *args, **kwargs)
            if result is not None and result.strip():  # 检查结果是否为非 None 且非空字符串
                with result_lock:
                    review_results.append(result)
@mimo-x mimo-x added the will_fix we got your idea ,we will fix label Mar 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
will_fix we got your idea ,we will fix
Projects
None yet
Development

No branches or pull requests

2 participants