|
3 | 3 | from __future__ import annotations |
4 | 4 |
|
5 | 5 | import hashlib |
| 6 | +import json |
6 | 7 | from dataclasses import replace |
| 8 | +from pathlib import Path |
7 | 9 |
|
8 | 10 | import pytest |
9 | 11 |
|
10 | 12 | from pkcs11_check.core.evidence.admit import ( |
| 13 | + EMPTY_SHARD_SHA256, |
11 | 14 | PredeclaredRoster, |
12 | 15 | ShardExpectation, |
13 | 16 | admit_lane, |
@@ -232,3 +235,116 @@ def test_obligation_membership() -> None: |
232 | 235 | compile_obligations({"a": {}}, {"cases": ["a", "zzz"]}) |
233 | 236 | with pytest.raises(ValueError): |
234 | 237 | compile_obligations({"a": {}}, {}) |
| 238 | + |
| 239 | + |
| 240 | +def test_roster_rejects_zero_records_at_construction() -> None: |
| 241 | + """R19: a roster shard declaring records=0 is rejected when built.""" |
| 242 | + with pytest.raises(ValueError): |
| 243 | + ShardExpectation(records=0, sha256=EMPTY_SHARD_SHA256) |
| 244 | + with pytest.raises(ValueError): |
| 245 | + ShardExpectation(records=-1, sha256=EMPTY_SHARD_SHA256) |
| 246 | + # Control: records >= 1 still builds. |
| 247 | + ShardExpectation(records=1, sha256=EMPTY_SHARD_SHA256) |
| 248 | + |
| 249 | + |
| 250 | +def test_roster_complete_absent_shard_always_fails() -> None: |
| 251 | + """R19: every roster shard must be present in rows -- no unless-clause.""" |
| 252 | + obligations = ObligationInventory(members=frozenset()) |
| 253 | + roster = PredeclaredRoster( |
| 254 | + lane="soft", |
| 255 | + shards={"never_arrived": ShardExpectation(records=1, sha256="0" * 64)}, |
| 256 | + ) |
| 257 | + # Reviewer probe shape: empty rows + absent shard must fail, not admit. |
| 258 | + verdict = admit_lane(_header([]), [], roster, obligations) |
| 259 | + assert not verdict.admitted |
| 260 | + assert _failed_with(verdict.failures, "roster_complete") |
| 261 | + |
| 262 | + # Absent shard alongside otherwise-clean rows must also fail. |
| 263 | + header, rows, clean_roster, _ = _clean_lane() |
| 264 | + shards = dict(clean_roster.shards) |
| 265 | + shards["ghost"] = ShardExpectation(records=2, sha256="1" * 64) |
| 266 | + verdict = admit_lane(header, rows, replace(clean_roster, shards=shards), obligations) |
| 267 | + assert not verdict.admitted |
| 268 | + assert _failed_with(verdict.failures, "roster_complete") |
| 269 | + |
| 270 | + |
| 271 | +def test_loader_missing_incomplete_key_fails_closed(tmp_path: Path) -> None: |
| 272 | + """R20: end-to-end -- header counters without `incomplete` fail at load.""" |
| 273 | + from pkcs11_check.core.evidence import load_ledger |
| 274 | + |
| 275 | + header, rows, _, _ = _clean_lane() |
| 276 | + ledger = tmp_path / "ledger.jsonl" |
| 277 | + header_record = header.to_record() |
| 278 | + del header_record["counters"]["incomplete"] |
| 279 | + ledger.write_text( |
| 280 | + "\n".join( |
| 281 | + [ |
| 282 | + json.dumps(header_record, sort_keys=True), |
| 283 | + *(json.dumps(row.to_record(), sort_keys=True) for row in rows), |
| 284 | + ] |
| 285 | + ) |
| 286 | + + "\n", |
| 287 | + encoding="utf-8", |
| 288 | + ) |
| 289 | + with pytest.raises(ValueError, match="incomplete"): |
| 290 | + load_ledger(ledger) |
| 291 | + |
| 292 | + |
| 293 | +def test_loader_full_header_loads_and_admits(tmp_path: Path) -> None: |
| 294 | + """R20 control: a complete header loads and the lane admits.""" |
| 295 | + from pkcs11_check.core.evidence import load_ledger |
| 296 | + |
| 297 | + header, rows, _, obligations = _clean_lane() |
| 298 | + ledger = tmp_path / "ledger.jsonl" |
| 299 | + ledger.write_text( |
| 300 | + "\n".join( |
| 301 | + [ |
| 302 | + json.dumps(header.to_record(), sort_keys=True), |
| 303 | + *(json.dumps(row.to_record(), sort_keys=True) for row in rows), |
| 304 | + ] |
| 305 | + ) |
| 306 | + + "\n", |
| 307 | + encoding="utf-8", |
| 308 | + ) |
| 309 | + loaded_header, loaded_rows = load_ledger(ledger) |
| 310 | + verdict = admit_lane(loaded_header, loaded_rows, _roster(loaded_rows), obligations) |
| 311 | + assert verdict.admitted |
| 312 | + assert verdict.failures == [] |
| 313 | + |
| 314 | + |
| 315 | +def test_shard_digest_golden_fixture() -> None: |
| 316 | + """Independent golden pin of the P11Lab-reused canonicalization. |
| 317 | +
|
| 318 | + Canonical bytes are handwritten below; the digest literal was computed |
| 319 | + with shell ``sha256sum`` over those exact bytes (no trailing newline), |
| 320 | + independently of ``shard_digest``. |
| 321 | + """ |
| 322 | + blob_low = b'{"attempt":1,"outcome":"passed"}' |
| 323 | + blob_high = b'{"attempt":2,"outcome":"failed"}' |
| 324 | + row_low = {"outcome": "passed", "attempt": 1} |
| 325 | + row_high = {"outcome": "failed", "attempt": 2} |
| 326 | + assert row_blob(row_low) == blob_low |
| 327 | + assert row_blob(row_high) == blob_high |
| 328 | + # Rows passed in reverse byte order: sorting + b"\\n" join are pinned too. |
| 329 | + assert ( |
| 330 | + shard_digest([row_high, row_low]) |
| 331 | + == "7fe9e7768bcd63c10328e3d9daf94a351bd4de8cc3566e65609a3e3f40f5edf5" |
| 332 | + ) |
| 333 | + |
| 334 | + |
| 335 | +def test_occurrence_preserved_duplicate_attempts() -> None: |
| 336 | + """Attempts [1, 1, 2] with attempts_total=3 fail occurrence_preserved.""" |
| 337 | + rows = [_row("tests/a.py::t", attempt=attempt, attempts_total=3) for attempt in (1, 1, 2)] |
| 338 | + obligations = ObligationInventory(members=frozenset()) |
| 339 | + verdict = admit_lane(_header(rows), rows, _roster(rows), obligations) |
| 340 | + assert not verdict.admitted |
| 341 | + assert _failed_with(verdict.failures, "occurrence_preserved") |
| 342 | + |
| 343 | + |
| 344 | +def test_occurrence_preserved_off_by_one_attempts() -> None: |
| 345 | + """Attempts [2, 3, 4] with attempts_total=3 fail occurrence_preserved.""" |
| 346 | + rows = [_row("tests/a.py::t", attempt=attempt, attempts_total=3) for attempt in (2, 3, 4)] |
| 347 | + obligations = ObligationInventory(members=frozenset()) |
| 348 | + verdict = admit_lane(_header(rows), rows, _roster(rows), obligations) |
| 349 | + assert not verdict.admitted |
| 350 | + assert _failed_with(verdict.failures, "occurrence_preserved") |
0 commit comments