Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GitHub action checks on PR always show failure #19

Closed
shadowspawn opened this issue Jan 6, 2023 · 1 comment · Fixed by #20
Closed

GitHub action checks on PR always show failure #19

shadowspawn opened this issue Jan 6, 2023 · 1 comment · Fixed by #20

Comments

@shadowspawn
Copy link
Collaborator

The pull requests all show a red x from the checks. I am not sure if this is because of the failing build for Node.js 0.6, or because of the "!" messages?

If it it due to 0.6 then I vote for disabling that test to reduce the noise! I haven't worked out an easy way to scan the failing checks for ones I caused rather than failures due to the action itself.


From a recent build, it looks like nvm fails to install 0.6 rather than because the tests fail on 0.6 as such:

I see there is an old issue open on the action: ljharb/actions#1

@ljharb
Copy link
Member

ljharb commented Jan 6, 2023

Yes, it's due to 0.6, and it's also due to github actions lacking the otherwise-universal CI feature of "allow failure".

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants