[patch]: test for boolean in setarg should include aliases #34
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more @@ Coverage Diff @@
## main #34 +/- ##
=======================================
Coverage 98.78% 98.78%
=======================================
Files 1 1
Lines 165 165
Branches 70 70
=======================================
Hits 163 163
Misses 2 2
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
shadowspawn
changed the title
shadowspawn
force-pushed
the
fix/31
branch
3 times, most recently
from
c38e4cf to
ab5ac7e
Compare
|
(Update: reworked test to follow the example used in #31, rather than use |
ljharb
approved these changes
Apr 15, 2023
Brutussss
approved these changes
Jun 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The check for a boolean option when setting value should take into account aliases. Adding more for completeness and consistency than a practical concern, as especially after other similar bugs checking for aliases of boolean are fixed, this is less likely to come up in a real program!
Found by code inspection, not from usage.
I added a new test file to cover the main behaviours of the existing automatic array behaviour, and then tests related to the bug fix in this PR.
Fixes: #31