Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Browser support leftovers in package.json #56

Closed
meszaros-lajos-gyorgy opened this issue Dec 21, 2023 · 3 comments
Closed

Browser support leftovers in package.json #56

meszaros-lajos-gyorgy opened this issue Dec 21, 2023 · 3 comments

Comments

@meszaros-lajos-gyorgy
Copy link

Hi guys, I was checking out this repo's package.json and I saw that there is this "testling" block with various browser versions for this package. This is a nodejs application for parsing command line arguments, there is no need to keep that section in there as far as I know.

I did some digging around in the git history and found that it was added to the original repo 10 years ago in this commit: 84c0370

Notice that the readme also contained a browser support badge, which was removed in 2020 by substack in this commit: 67d3722

It looks like the testling part was forgotten and accidentally left in there.

@ljharb
Copy link
Member

ljharb commented Dec 21, 2023

Sure, it does no harm by being there but it’s fine to remove it.

@shadowspawn
Copy link
Collaborator

(Thanks for digging into the history.)

@ljharb
Copy link
Member

ljharb commented Mar 2, 2024

In 6715df1 i removed browsers, since the testling service is dead. However, I still use the testling cli package, which requires the files key, so that remains.

@ljharb ljharb closed this as completed Mar 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants