[kernel][mp] use proper types when computing idle and active cpus

travisg · travisg · commit 0ac7a2d7cbd3 · 2025-01-11T16:59:42.000-08:00
Also return a proper bool instead of an int. No functional change.
diff --git a/kernel/include/kernel/mp.h b/kernel/include/kernel/mp.h
@@ -49,12 +49,12 @@ struct mp_state {
 
 extern struct mp_state mp;
 
-static inline int mp_is_cpu_active(uint cpu) {
-    return mp.active_cpus & (1 << cpu);
+static inline bool mp_is_cpu_active(uint cpu) {
+    return mp.active_cpus & (1UL << cpu);
 }
 
-static inline int mp_is_cpu_idle(uint cpu) {
-    return mp.idle_cpus & (1 << cpu);
+static inline bool mp_is_cpu_idle(uint cpu) {
+    return mp.idle_cpus & (1UL << cpu);
 }
 
 /* must be called with the thread lock held */

Original file line number	Diff line number	Diff line change
`@@ -49,12 +49,12 @@ struct mp_state {`
`49`	`49`
`50`	`50`	`extern struct mp_state mp;`
`51`	`51`
`52`		`-static inline int mp_is_cpu_active(uint cpu) {`
`53`		`- return mp.active_cpus & (1 << cpu);`
	`52`	`+static inline bool mp_is_cpu_active(uint cpu) {`
	`53`	`+ return mp.active_cpus & (1UL << cpu);`
`54`	`54`	`}`
`55`	`55`
`56`		`-static inline int mp_is_cpu_idle(uint cpu) {`
`57`		`- return mp.idle_cpus & (1 << cpu);`
	`56`	`+static inline bool mp_is_cpu_idle(uint cpu) {`
	`57`	`+ return mp.idle_cpus & (1UL << cpu);`
`58`	`58`	`}`
`59`	`59`
`60`	`60`	`/* must be called with the thread lock held */`