Skip to content

Commit dcd374a

Browse files
fix an easily broken test (#2927)
1 parent 25b23ee commit dcd374a

File tree

1 file changed

+11
-16
lines changed

1 file changed

+11
-16
lines changed

frontends/main/src/app-pages/HomePage/HomePage.test.tsx

Lines changed: 11 additions & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -50,17 +50,17 @@ const setupAPIs = () => {
5050
setMockResponse.get(urls.userLists.membershipList(), [])
5151
setMockResponse.get(urls.learningPaths.membershipList(), [])
5252

53-
const resources = learningResources.resources({ count: 4 })
53+
const featured = learningResources.resources({ count: 2 })
54+
const media = learningResources.resources({ count: 2 })
5455
const attestations = testimonials.testimonials({ count: 3 })
5556

5657
setMockResponse.get(
57-
expect.stringContaining(urls.learningResources.list()),
58-
resources,
58+
expect.stringContaining(urls.learningResources.featured()),
59+
featured,
5960
)
60-
6161
setMockResponse.get(
62-
expect.stringContaining(urls.learningResources.featured()),
63-
resources,
62+
expect.stringContaining(urls.learningResources.list()),
63+
media,
6464
)
6565

6666
setMockResponse.get(
@@ -90,6 +90,7 @@ const setupAPIs = () => {
9090
)
9191

9292
mockedUseFeatureFlagEnabled.mockReturnValue(false)
93+
return { featured, media }
9394
}
9495

9596
describe("Home Page Hero", () => {
@@ -341,24 +342,18 @@ describe("Home Page Carousel", () => {
341342
})
342343

343344
test("Headings", async () => {
344-
setupAPIs()
345-
346-
setMockResponse.get(
347-
expect.stringContaining(urls.learningResources.list()),
348-
[],
349-
)
350-
setMockResponse.get(
351-
expect.stringContaining(urls.learningResources.featured()),
352-
[],
353-
)
345+
const { featured, media } = setupAPIs()
354346

355347
renderWithProviders(<HomePage heroImageIndex={1} />)
356348
await waitFor(() => {
357349
assertHeadings([
358350
{ level: 1, name: "Learn with MIT" },
359351
{ level: 2, name: "Featured Courses" },
352+
// Featured course order is randomized on frontend, so just check for presence
353+
...featured.results.map(() => ({ level: 3, name: expect.any(String) })),
360354
{ level: 2, name: "Continue Your Journey" },
361355
{ level: 2, name: "Media" },
356+
...media.results.map((result) => ({ level: 3, name: result.title })),
362357
{ level: 2, name: "Browse by Topic" },
363358
{ level: 2, name: "From Our Community" },
364359
{ level: 2, name: "MIT Stories & Events" },

0 commit comments

Comments
 (0)