remove default value for generate_embeddings in pluggy plugin (#2821)

* removing default for generate_embeddings pluggy argument

* fixing test

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* None to False

* Revert "None to False"

This reverts commit c60a432.

* None to False

* Revert "None to False"

This reverts commit 3d7fdea.

* None to False

---------

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>

Author: shanbady

channels/plugins.py

@@ -165,7 +165,7 @@ def offeror_delete(self, offeror):
         offeror.delete()
 
     @hookimpl
-    def resource_upserted(self, resource, percolate, *, generate_embeddings=True):  # noqa: ARG002
+    def resource_upserted(self, resource, percolate, generate_embeddings):  # noqa: ARG002
         """
         Publish channels for the resource's topics
         """

channels/plugins_test.py

@@ -216,8 +216,9 @@ def test_resource_upserted():
     resource = LearningResourceFactory.create(
         topics=[channel1.topic_detail.topic, channel2.topic_detail.topic]
     )
-    ChannelPlugin().resource_upserted(resource, None)
-
+    ChannelPlugin().resource_upserted(
+        resource, percolate=False, generate_embeddings=False
+    )
     channel1.refresh_from_db()
     channel2.refresh_from_db()
     channel3.refresh_from_db()

learning_resources/etl/loaders.py

@@ -80,7 +80,9 @@ def update_index(learning_resource, newly_created):
     ):
         resource_unpublished_actions(learning_resource)
     elif learning_resource.published:
-        resource_upserted_actions(learning_resource, percolate=False)
+        resource_upserted_actions(
+            learning_resource, percolate=False, generate_embeddings=True
+        )
 
 
 def load_topics(resource, topics_data):

learning_resources/hooks.py

@@ -29,7 +29,7 @@ def percolate_query_delete(self, percolate_query):
         """Trigger actions after a percolate query is deleted"""
 
     @hookspec
-    def resource_upserted(self, resource, percolate, *, generate_embeddings=True):
+    def resource_upserted(self, resource, percolate, generate_embeddings):
         """Trigger actions after a learning resource is created or updated"""
 
     @hookspec

learning_resources/tasks.py

@@ -81,7 +81,9 @@ def update_next_start_date_and_prices():
     for resource in resources:
         load_run_dependent_values(resource)
         if resource.published:
-            resource_upserted_actions(resource, percolate=False)
+            resource_upserted_actions(
+                resource, percolate=False, generate_embeddings=True
+            )
     clear_views_cache()
     return len(resources)
 

learning_resources/tasks_test.py

@@ -492,7 +492,9 @@ def test_update_next_start_date(mocker, published):
     update_next_start_date_and_prices()
     mock_load_next_start_date.assert_called_once_with(learning_resource)
     if published:
-        mock_upsert_index.assert_called_once_with(learning_resource, percolate=False)
+        mock_upsert_index.assert_called_once_with(
+            learning_resource, percolate=False, generate_embeddings=True
+        )
     else:
         mock_upsert_index.assert_not_called()
 

learning_resources/utils.py

@@ -273,7 +273,7 @@ def get_ocw_topics(topics_collection):
 
 
 def resource_upserted_actions(
-    resource: LearningResource, percolate, *, generate_embeddings=True
+    resource: LearningResource, percolate, generate_embeddings
 ):
     """
     Trigger plugins when a LearningResource is created or updated

learning_resources/utils_test.py

@@ -243,7 +243,9 @@ def test_resource_upserted_actions(mock_plugin_manager, fixture_resource):
     """
     resource_upserted_actions function should trigger plugin hook's resource_upserted function
     """
-    utils.resource_upserted_actions(fixture_resource, percolate=False)
+    utils.resource_upserted_actions(
+        fixture_resource, percolate=False, generate_embeddings=True
+    )
     mock_plugin_manager.hook.resource_upserted.assert_called_once_with(
         resource=fixture_resource, percolate=False, generate_embeddings=True
     )

learning_resources_search/plugins.py

@@ -63,7 +63,7 @@ def document_percolated(self, resource, percolated_queries):
         log.debug("document %i percolated - %s", resource.id, list(percolated_queries))
 
     @hookimpl
-    def resource_upserted(self, resource, percolate, *, generate_embeddings=True):
+    def resource_upserted(self, resource, percolate, generate_embeddings):
         """
         Upsert a created/modified resource to the search index
 

learning_resources_search/plugins_test.py

@@ -60,7 +60,9 @@ def test_search_index_plugin_resource_upserted(
 ):
     """The plugin function should upsert a resource to the search index"""
     resource = LearningResourceFactory.create(resource_type=resource_type)
-    SearchIndexPlugin().resource_upserted(resource, percolate=False)
+    SearchIndexPlugin().resource_upserted(
+        resource, percolate=False, generate_embeddings=False
+    )
 
     mock_search_index_helpers.mock_upsert_learning_resource_immutable_signature.assert_called_once_with(
         resource.id