Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removing a tag from a repo that doesn't have the tag removes the tag from another random repo #84

Open
n1ywb opened this issue Jun 11, 2018 · 0 comments

Comments

@n1ywb
Copy link

n1ywb commented Jun 11, 2018

I start out with 3 repos with the @premajor tag, and I am in one of them

When I remove the tag from the current repo, it works as expected

when I try to remove the tag AGAIN from the current repo (which no longer has the tag) it removes the tag from a different repo which completely borks up my git run tags

also gr crashes with an ugly message when you ask for the status of a tag with zero repos

(rp_bower) jeff@ta00491-Jeff ~/readingplus/rp_bower/emerson-report-client $ gr @premajor status
~/readingplus/rp_bower/app-datepicker         master         Clean        [ahead 2]    @rp @con @rp_bower @premajor
~/readingplus/rp_bower/emerson-report-client  master         Clean                     @rp_bower @premajor
~/readingplus/rp_bower/emerson-settings       master         Clean                     @rp @con @rp_bower @premajor
(rp_bower) jeff@ta00491-Jeff ~/readingplus/rp_bower/emerson-report-client $ gr tag rm premajor
gr-tag info remove tags.premajor /home/jeff/readingplus/rp_bower/emerson-report-client => [ '/home/jeff/readingplus/rp_bower/emerson-settings',
  '/home/jeff/readingplus/rp_bower/app-datepicker' ]
(rp_bower) jeff@ta00491-Jeff ~/readingplus/rp_bower/emerson-report-client $ gr @premajor status
~/readingplus/rp_bower/app-datepicker    master         Clean        [ahead 2]    @rp @con @rp_bower @premajor
~/readingplus/rp_bower/emerson-settings  master         Clean                     @rp @con @rp_bower @premajor
(rp_bower) jeff@ta00491-Jeff ~/readingplus/rp_bower/emerson-report-client $ gr tag rm premajor
gr-tag info remove tags.premajor /home/jeff/readingplus/rp_bower/emerson-report-client => [ '/home/jeff/readingplus/rp_bower/emerson-settings' ]
(rp_bower) jeff@ta00491-Jeff ~/readingplus/rp_bower/emerson-report-client $ gr @premajor status
~/readingplus/rp_bower/emerson-settings  master         Clean                     @rp @con @rp_bower @premajor
(rp_bower) jeff@ta00491-Jeff ~/readingplus/rp_bower/emerson-report-client $ gr tag rm premajor
gr-tag info remove tags.premajor /home/jeff/readingplus/rp_bower/emerson-report-client => []
(rp_bower) jeff@ta00491-Jeff ~/readingplus/rp_bower/emerson-report-client $ gr @premajor status
/home/jeff/readingplus/gr/lib/command-requirements.js:8
    if (gitCommand.stderr.toString().replace(/(\r\n|\n|\r)/gm, '').trim()) {
                          ^

TypeError: Cannot read property 'toString' of null
    at Object.git (/home/jeff/readingplus/gr/lib/command-requirements.js:8:27)
    at Object.module.exports [as handle] (/home/jeff/readingplus/gr/plugins/status.js:27:28)
    at next (/home/jeff/readingplus/gr/index.js:244:11)
    at next (/home/jeff/readingplus/gr/index.js:227:14)
    at next (/home/jeff/readingplus/gr/index.js:227:14)
    at next (/home/jeff/readingplus/gr/index.js:227:14)
    at next (/home/jeff/readingplus/gr/index.js:227:14)
    at next (/home/jeff/readingplus/gr/index.js:227:14)
    at next (/home/jeff/readingplus/gr/index.js:227:14)
    at next (/home/jeff/readingplus/gr/index.js:227:14)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant