Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

node-fetch-server: http2 support #42

Open
eugene1g opened this issue Jan 8, 2025 · 2 comments
Open

node-fetch-server: http2 support #42

eugene1g opened this issue Jan 8, 2025 · 2 comments

Comments

@eugene1g
Copy link

eugene1g commented Jan 8, 2025

Hi @mjackson ,

I'd like node-fetch-server to support node:http2 - would you be open to a PR for this, or is the scope now fixed?

@mjackson
Copy link
Owner

mjackson commented Jan 9, 2025

I'd be open to supporting http/2, but honestly I don't have a lot of experience building h2 servers. What do you think a high-level API might look like?

@eugene1g
Copy link
Author

eugene1g commented Jan 9, 2025

Thanks! The API will be the same, perhaps even using createRequestListener for both HTTP1 and HTTP2.

I built another library to do this 1-2 years ago and recently thought about open open-sourcing it, then found node-fetch-server. You and I used more or less the same strategy, and the libraries have nearly identical performance, so the only thing missing from node-fetch-server is HTTP2 support. Might as well merge my work into this.

I'll put together a PR with tests for you to look over.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants