[FIX] point_of_sale, l10n_ch_pos: missing bank recipient pos invoice

Steps:

- Install l10n_fr and make sure fr company has tax id filled
- Go to bank journal and set a bank account number
- Go to Customer invoice journal and check `Factur-X` in the
  Advenced Settings tab
- Create a french customer F with an email address
- Open a pos session, and make an invoice forF for a product with tax,
  select Bank payment method and confirm
- Go to invoices and select the newly created invoice
-> "Error occured while creating the EDI document"

Cause:

The field `partner_bank_id` is not set from the pos order to the invoice

cbe1cf5 added a condition specifically
for swiss localisation.

Fix:

Movr the condition to a bridge module for swiss localisation

opw-3992498

closes odoo#170933

X-original-commit: ac005d5
Signed-off-by: Vlad Stroia (vlst) <[email protected]>
Signed-off-by: Guillaume Vanleynseele (guva) <[email protected]>

Author: guva-odoo

addons/l10n_ch_pos/__init__.py

@@ -0,0 +1,3 @@
+# Part of Odoo. See LICENSE file for full copyright and licensing details.
+
+from . import models

addons/l10n_ch_pos/__manifest__.py

@@ -0,0 +1,14 @@
+# Part of Odoo. See LICENSE file for full copyright and licensing details.
+{
+    'name': 'Swiss - Point of Sale',
+    'author': 'Odoo PS',
+    'category': 'Accounting/Localizations/Point of Sale',
+    'description': """
+Swiss POS Localization
+=======================================================
+    """,
+    'depends': ['l10n_ch', 'point_of_sale'],
+    'auto_install': True,
+    'installable': True,
+    'license': 'LGPL-3',
+}

addons/l10n_ch_pos/models/__init__.py

@@ -0,0 +1,3 @@
+# Part of Odoo. See LICENSE file for full copyright and licensing details.
+
+from . import pos_order

addons/l10n_ch_pos/models/pos_order.py

@@ -0,0 +1,15 @@
+# Part of Odoo. See LICENSE file for full copyright and licensing details.
+from odoo import models
+
+
+class PosOrder(models.Model):
+    _name = "pos.order"
+    _inherit = ["pos.order"]
+
+    def _get_partner_bank_id(self):
+        bank_partner_id = super()._get_partner_bank_id()
+        swiss_order = self.filtered(lambda o: o.company_id.country_code == 'CH')
+        if swiss_order:
+            has_pay_later = any(not pm.journal_id for pm in swiss_order.payment_ids.mapped('payment_method_id'))
+            bank_partner_id = bank_partner_id if has_pay_later else False
+        return bank_partner_id

addons/point_of_sale/models/pos_order.py

@@ -528,12 +528,10 @@ def _get_rounded_amount(self, amount, force_round=False):
 
     def _get_partner_bank_id(self):
         bank_partner_id = False
-        has_pay_later = any(not pm.journal_id for pm in self.payment_ids.mapped('payment_method_id'))
-        if has_pay_later:
-            if self.amount_total <= 0 and self.partner_id.bank_ids:
-                bank_partner_id = self.partner_id.bank_ids[0].id
-            elif self.amount_total >= 0 and self.company_id.partner_id.bank_ids:
-                bank_partner_id = self.company_id.partner_id.bank_ids[0].id
+        if self.amount_total <= 0 and self.partner_id.bank_ids:
+            bank_partner_id = self.partner_id.bank_ids[0].id
+        elif self.amount_total >= 0 and self.company_id.partner_id.bank_ids:
+            bank_partner_id = self.company_id.partner_id.bank_ids[0].id
         return bank_partner_id
 
     def _create_invoice(self, move_vals):