[REF] l10n_it_edi_doi: move 'qty_invoiced_posted' to 'sale'

The field was added in stable for a specific use case.

It is now moved to its rightful place, where it was
originally needed.

closes odoo#164963

Related: odoo/enterprise#62208
Related: odoo/upgrade#6425
Signed-off-by: William André (wan) <wan@odoo.com>

Author: epictete

addons/account/models/account_move.py

@@ -1596,7 +1596,7 @@ def _compute_partner_credit_warning(self):
             move.partner_credit_warning = ''
             show_warning = move.state == 'draft' and \
                            move.move_type == 'out_invoice' and \
-                           self.env.company.account_use_credit_limit
+                           move.company_id.account_use_credit_limit
             if show_warning:
                 total_field = 'amount_total' if move.currency_id == move.company_currency_id else 'amount_total_company_currency'
                 current_amount = move.tax_totals[total_field]

addons/l10n_it_edi_doi/models/__init__.py

@@ -7,4 +7,3 @@
 from . import res_company
 from . import res_partner
 from . import sale_order
-from . import sale_order_line

addons/l10n_it_edi_doi/models/sale_order_line.py

@@ -652,11 +652,8 @@ def _compute_tax_country_id(self):
 
     @api.depends('order_line.amount_to_invoice')
     def _compute_amount_to_invoice(self):
-        if not self.env.company.account_use_credit_limit:
-            self.amount_to_invoice = 0.0
-        else:
-            for order in self:
-                order.amount_to_invoice = sum(order.order_line.mapped('amount_to_invoice'))
+        for order in self:
+            order.amount_to_invoice = sum(order.order_line.mapped('amount_to_invoice'))
 
     @api.depends('order_line.amount_invoiced')
     def _compute_amount_invoiced(self):
@@ -669,7 +666,7 @@ def _compute_partner_credit_warning(self):
             order.with_company(order.company_id)
             order.partner_credit_warning = ''
             show_warning = order.state in ('draft', 'sent') and \
-                           self.env.company.account_use_credit_limit
+                           order.company_id.account_use_credit_limit
             if show_warning:
                 order.partner_credit_warning = self.env['account.move']._build_credit_warning_message(
                     order,

addons/sale/models/sale_order.py

@@ -1062,8 +1062,6 @@ def _compute_untaxed_amount_to_invoice(self):
 
     @api.depends('discount', 'price_total', 'product_uom_qty', 'qty_delivered', 'qty_invoiced_posted')
     def _compute_amount_to_invoice(self):
-        if not self.company_id.account_use_credit_limit:
-            self.amount_to_invoice = 0.0
         for line in self:
             if line.product_uom_qty:
                 uom_qty_to_consider = line.qty_delivered if line.product_id.invoice_policy == 'delivery' else line.product_uom_qty

addons/sale/models/sale_order_line.py

@@ -48,14 +48,13 @@ def test_credit_limit_multi_company(self):
             'order_line': [Command.create({
                 'product_id': self.company_data_2['product_order_no'].id,
                 'price_unit': 1000.0,
-            })]
+            })],
         })
 
-        self.assertEqual(self.partner_a.credit_to_invoice, 0.0)
+        self.assertEqual(self.partner_a.with_company(company2).credit_to_invoice, 0.0)
         sale_order.action_confirm()
 
         self.partner_a.invalidate_recordset(['credit', 'credit_to_invoice'])
-        self.assertEqual(self.partner_a.credit_to_invoice, 0.0)
         self.assertEqual(self.partner_a.with_company(company2).credit_to_invoice, 1000.0)
         partner_a_multi_company = self.partner_a.with_context(allowed_company_ids=[self.env.company.id, company2.id])
         self.assertEqual(partner_a_multi_company.credit_to_invoice, 0.0)

addons/sale/tests/test_credit_limit.py

@@ -938,7 +938,6 @@ def test_amount_to_invoice_multiple_so(self):
         """ Testing creating two SOs with the same customer and invoicing them together. We have to ensure
             that the amount to invoice is correct for each SO.
         """
-        self.env.company.account_use_credit_limit = True
         sale_order_1 = self.env['sale.order'].create({
             'partner_id': self.partner_a.id,
             'order_line': [
@@ -977,7 +976,6 @@ def test_amount_to_invoice_one_line_multiple_so(self):
         """ Testing creating two SOs linked to the same invoice line. Drawback: the substracted
             amount to the amount_total will take both sale order into account.
         """
-        self.env.company.account_use_credit_limit = True
         sale_order_1 = self.env['sale.order'].create({
             'partner_id': self.partner_a.id,
             'order_line': [
@@ -1020,7 +1018,6 @@ def test_amount_to_invoice_price_unit_change(self):
         We check that the 'amount_to_invoice' relies only on the posted invoice quantity,
         and is not affected by price changes that occurred during invoice creation.
         """
-        self.env.company.account_use_credit_limit = True
         so = self.env['sale.order'].create({
             'partner_id': self.partner_a.id,
             'partner_invoice_id': self.partner_a.id,