Support Object Definition in Python

Author: potatomashed

.github/workflows/ci.yml

@@ -9,7 +9,7 @@ env:
   MLC_PYTHON_VERSION: "3.9"
   MLC_CIBW_WIN_BUILD: "cp39-win_amd64"
   MLC_CIBW_MAC_BUILD: "cp39-macosx_arm64"
-  MLC_CIBW_LINUX_BUILD: "cp313-manylinux_x86_64"
+  MLC_CIBW_LINUX_BUILD: "cp312-manylinux_x86_64"
 
 jobs:
   pre-commit:

CMakeLists.txt

@@ -2,7 +2,7 @@ cmake_minimum_required(VERSION 3.15)
 
 project(
   mlc
-  VERSION 0.0.4
+  VERSION 0.0.5
   DESCRIPTION "PyMLC"
   LANGUAGES C CXX
 )

README.md

@@ -1,8 +1,13 @@
-PyMLC
-=====
+MLC-Python
+==========
 
-## Features
+## Installation
 
+```bash
+pip install -U mlc-python
+```
+
+## Features
 
 TBA
 
@@ -16,12 +21,6 @@ TBA
 
 ## Development
 
-### Install from PyPI
-
-```bash
-pip install mlc-python
-```
-
 ### Build from Source
 
 ```bash

cpp/c_api.cc

@@ -1,7 +1,5 @@
 #include "./registry.h"
-#if defined(__APPLE__)
 #include <iostream>
-#endif
 
 namespace mlc {
 namespace registry {
@@ -31,10 +29,9 @@ MLC_API MLCAny MLCGetLastError() {
 }
 
 MLC_API int32_t MLCTypeRegister(MLCTypeTableHandle _self, int32_t parent_type_index, const char *type_key,
-                                int32_t type_index, MLCAttrGetterSetter getter, MLCAttrGetterSetter setter,
-                                MLCTypeInfo **out_type_info) {
+                                int32_t type_index, MLCTypeInfo **out_type_info) {
   MLC_SAFE_CALL_BEGIN();
-  *out_type_info = TypeTable::Get(_self)->TypeRegister(parent_type_index, type_index, type_key, getter, setter);
+  *out_type_info = TypeTable::Get(_self)->TypeRegister(parent_type_index, type_index, type_key);
   MLC_SAFE_CALL_END(&last_error);
 }
 
@@ -146,3 +143,33 @@ MLC_API int32_t MLCErrorGetInfo(MLCAny error, int32_t *num_strs, const char ***s
   *strs = ret.data();
   MLC_SAFE_CALL_END(&last_error);
 }
+
+MLC_API void *MLCExtObjCreate(int32_t bytes, int32_t type_index) {
+  char *data = new char[bytes]();
+  std::memset(data, 0, bytes);
+  MLCAny *header = reinterpret_cast<MLCAny *>(data);
+  header->type_index = type_index;
+  header->ref_cnt = 0;
+  header->deleter = MLCExtObjDelete;
+  return data;
+}
+
+MLC_API void MLCExtObjDelete(void *objptr) {
+  MLCAny *header = reinterpret_cast<MLCAny *>(objptr);
+  MLCTypeInfo *info = TypeTable::Global()->GetTypeInfo(header->type_index);
+  if (info == nullptr) { // TODO: error handling
+    std::cerr << "Cannot find type info for type index: " << header->type_index << std::endl;
+    std::abort();
+  }
+  MLCTypeField *fields = info->fields;
+  for (int32_t i = 0;; i++) {
+    MLCTypeField &field = fields[i];
+    if (field.name == nullptr) {
+      break;
+    }
+    if (field.is_owned_obj_ptr) {
+      MLCObject *ptr = reinterpret_cast<MLCObjPtr *>(static_cast<char *>(objptr) + field.offset)->ptr;
+      ::mlc::base::DecRef(ptr);
+    }
+  }
+}

cpp/c_api_tests.cc

@@ -30,8 +30,8 @@ struct ReflectionTest : public ObjectRef {
   MLC_DEF_OBJ_REF(ReflectionTest, ReflectionTestObj, ObjectRef)
       .Field("x_mutable", &ReflectionTestObj::x_mutable)
       .FieldReadOnly("y_immutable", &ReflectionTestObj::y_immutable)
-      .Method("__init__", InitOf<ReflectionTestObj, std::string, int32_t>)
-      .Method("YPlusOne", &ReflectionTestObj::YPlusOne);
+      .StaticFn("__init__", InitOf<ReflectionTestObj, std::string, int32_t>)
+      .MemFn("YPlusOne", &ReflectionTestObj::YPlusOne);
 };
 
 /**************** Traceback ****************/
@@ -52,7 +52,7 @@ MLC_REGISTER_FUNC("mlc.testing.throw_exception_from_ffi").set_body([](FuncObj *f
   try {
     (*func)();
   } catch (Exception &error) {
-    error.MoveToAny(&ret);
+    ret = std::move(error.data_);
   }
   return ret;
 });