Updating dependencies and removing chokidar-cli#51
Merged
erinesullivan merged 1 commit intomainfrom Mar 22, 2022
Merged
Conversation
- `chokidar-cli` had vulnerabilities, and hasn't been updated in 8 months, even though issues are open in the repo.
niquerio
reviewed
Mar 22, 2022
Collaborator
niquerio
left a comment
niquerio
left a comment
There was a problem hiding this comment.
So is the idea now to run build manually when you want to see changes?
I'm Ok with getting rid of it, btw just making sure I know the implications. For ruby changes I have to keep restarting sinatra so that kind of thing is not a big deal for me.
Collaborator
Author
|
@niquerio Correct, which I do anyway. The majority of styling is practically done, so there shouldn't be many CSS changes in the future. |
Collaborator
|
Alright! Get rid of if then. If we want that functionality in the future there other ways to do it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
Updating
npmdependencies for the sake of security.This needs to be a monthly task.
chokidar-cli
chokidar-clihad several vulnerabilities, and has not been updated in 8 months. There is an issue that has been open for a few months to fix it. The package is only used to watch CSS changes, which is nice but is not required for development. I have made the decision to remove it.Testing
rm -rf node_modules/ && docker-compose run --rm web npm install).docker-compose run --rm web npm run build).