fix: wrong pred array size

Author: jobo322

src/__tests__/test.ts renamed to src/__tests__/index.test.ts

@@ -27,8 +27,8 @@ describe('linear sum problem', () => {
     const { columnAssignments, rowAssignments } = linearSumAssignment(diff, {
       maximaze: false,
     });
-    expect(columnAssignments).toMatchCloseTo([1, 2, 0, 3, 4, -1]);
-    expect(rowAssignments).toMatchCloseTo([2, 0, 1, 3, 4]);
+    expect(columnAssignments).toMatchCloseTo([2, 0, 1, 3, 4]);
+    expect(rowAssignments).toMatchCloseTo([1, 2, 0, 3, 4, -1]);
   });
   it('differents size: rows < columns', () => {
     const a = [3.1, 1.1, 1.9, 3.99, 5.2];
@@ -44,14 +44,14 @@ describe('linear sum problem', () => {
   });
   it('before failing case', () => {
     const diff = [
-      [0.10000000000000009, 0.5, 0.6000000000000001, 1.1],
-      [0.3999999999999999, 0, 0.10000000000000009, 0.6000000000000001],
-      [0.8999999999999999, 0.5, 0.3999999999999999, 0.10000000000000009],
+      [0.010000000000000009, 0.3999999999999999, 0.5, 1.0099999999999998],
+      [0.49, 0.10000000000000009, 0, 0.5099999999999998],
+      [0.99, 0.6000000000000001, 0.5, 0.009999999999999787],
     ];
     const { columnAssignments, rowAssignments } = linearSumAssignment(diff, {
       maximaze: false,
     });
-    expect(columnAssignments).toMatchCloseTo([0, 1, 2, -1]);
-    expect(rowAssignments).toMatchCloseTo([0, 1, 2]);
+    expect(columnAssignments).toMatchCloseTo([0, -1, 1, 2]);
+    expect(rowAssignments).toMatchCloseTo([0, 2, 3]);
   });
 });

src/getShortestPath.ts

@@ -24,7 +24,7 @@ export function getShortestPath(options: GetShortestPathOptions) {
   let nbRows = matrix.rows;
   let nbColumns = matrix.columns;
 
-  let pred = new Float64Array(nbColumns);
+  let pred = new Float64Array(nbRows);
   let scannedColumns = new Float64Array(nbColumns);
   let scannedRows = new Float64Array(nbRows);
 

src/index.ts

@@ -14,9 +14,8 @@ export default function linearSumAssignment(
   const { maximaze = true } = options;
 
   let matrix = Matrix.checkMatrix(input);
-
   let didFlip = false;
-  if (matrix.columns < matrix.rows) {
+  if (matrix.columns > matrix.rows) {
     didFlip = true;
     matrix = matrix.transpose();
   }