Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Combine unable to pull IPs from threat feed that have comments #165

Open
redlot10 opened this issue Sep 9, 2016 · 0 comments
Open

Combine unable to pull IPs from threat feed that have comments #165

redlot10 opened this issue Sep 9, 2016 · 0 comments

Comments

@redlot10
Copy link

redlot10 commented Sep 9, 2016

I noticed Combine is unable to pull IPs from threat feeds which start with #.

For example: When I supply the following URL in either the inbound_url.txt or outbound_ur.txt, I do not get any output in harvest.csv:

https://raw.githubusercontent.com/firehol/blocklist-ipsets/master/bds_atif.ipset

But when I provide the following URL which does not have any comments at the beginning of the IP feed, Combine is able to pull the IP list correctly:

http://malc0de.com/bl/IP_Blacklist.txt

Could you please update the code where if Combine sees # or a space at the beginning of the line, it should be able to just go to the next line and then start pulling out the relevant data (IPs, etc.)?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant