Skip to content

Add signature verification for plugins #145

@moallemi

Description

@moallemi

Summary

Plugin discovery currently trusts any installed app that:

  1. Exposes a service for io.filmtime.plugin.STREAM_PROVIDER
  2. Has a ContentProvider authority starting with io.filmtime.plugin

There is no signature/certificate verification before treating it as a trusted stream provider, which allows a malicious app to impersonate a plugin and supply arbitrary URLs/headers.

Proposed Solution

Add signing certificate verification (or an allowlist) before accepting a package as a plugin. Options to consider:

  • Allowlist approach: Maintain a list of known good plugin signing certificates
  • Signature verification: Verify plugins are signed with a specific key or set of keys
  • User consent: Show a warning for unsigned/unknown plugins and let users decide

Files to Modify

  • data/plugin-discovery/src/main/java/io/filmtime/data/plugin/discovery/PluginDiscoveryRepositoryImpl.kt

Related

Follow-up from #143 code review

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions