-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WCOW: RUN with bind/cache mounts #5603
Comments
You are right, they are related. I'm currently investigating how to support this, I will update. |
@danielnilsson9 -- I've got bind and cache mounts working and wanted your preliminary review on this as I complete out the rest of the stuff on the check-list -> #5708 |
Awesome! Greatly appreciated! I'm not sure I can help with a review as I'm not at all familiar with this codebase but I can put it to the test on our build servers as I intended for running C++ compilation in build containers on Windows. |
Sure, that will help, please do. Thanks! |
Currently, mounts are not supported for WCOW builds, see moby#5678. This commit introduces support for bind and cache mounts. The remaining two require a little more work and consultation with the platform teams for enlightment. WIP Checklist: - [x] Support for bind mounts - [x] Support for cache mounts - [x] add frontend/dockerfile integration tests - [ ] add client integration tests - [ ] add documentatio - [ ] add note and plan on the missing feature(s) i.e. secret mounts (that need tmpfs) - [ ] spec out / second attempt for SSH mount Fixes moby#5603 Addresses part of moby#5678 Signed-off-by: Anthony Nandaa <[email protected]>
Currently, mounts are not supported for WCOW builds, see moby#5678. This commit introduces support for bind and cache mounts. The remaining two require a little more work and consultation with the platform teams for enlightment. WIP Checklist: - [x] Support for bind mounts - [x] Support for cache mounts - [x] add frontend/dockerfile integration tests - [ ] add client integration tests - [ ] add documentatio - [ ] add note and plan on the missing feature(s) i.e. secret mounts (that need tmpfs) - [ ] spec out / second attempt for SSH mount Fixes moby#5603 Addresses part of moby#5678 Signed-off-by: Anthony Nandaa <[email protected]>
Currently, mounts are not supported for WCOW builds, see moby#5678. This commit introduces support for bind and cache mounts. The remaining two require a little more work and consultation with the platform teams for enlightment. WIP Checklist: - [x] Support for bind mounts - [x] Support for cache mounts - [x] add frontend/dockerfile integration tests - [ ] add client integration tests - [ ] add documentatio - [ ] add note and plan on the missing feature(s) i.e. secret mounts (that need tmpfs) - [ ] spec out / second attempt for SSH mount Fixes moby#5603 Addresses part of moby#5678 Signed-off-by: Anthony Nandaa <[email protected]>
Currently, mounts are not supported for WCOW builds, see moby#5678. This commit introduces support for bind and cache mounts. The remaining two require a little more work and consultation with the platform teams for enlightment. WIP Checklist: - [x] Support for bind mounts - [x] Support for cache mounts - [x] add frontend/dockerfile integration tests - [ ] add client integration tests - [ ] add documentatio - [ ] add note and plan on the missing feature(s) i.e. secret mounts (that need tmpfs) - [ ] spec out / second attempt for SSH mount Fixes moby#5603 Addresses part of moby#5678 Signed-off-by: Anthony Nandaa <[email protected]>
Currently, mounts are not supported for WCOW builds, see moby#5678. This commit introduces support for bind and cache mounts. The remaining two require a little more work and consultation with the platform teams for enlightment. WIP Checklist: - [x] Support for bind mounts - [x] Support for cache mounts - [x] add frontend/dockerfile integration tests - [ ] add client integration tests - [ ] add documentatio - [ ] add note and plan on the missing feature(s) i.e. secret mounts (that need tmpfs) - [ ] spec out / second attempt for SSH mount Fixes moby#5603 Signed-off-by: Anthony Nandaa <[email protected]>
Currently, mounts are not supported for WCOW builds, see moby#5678. This commit introduces support for bind and cache mounts. The remaining two require a little more work and consultation with the platform teams for enlightment. WIP Checklist: - [x] Support for bind mounts - [x] Support for cache mounts - [x] add frontend/dockerfile integration tests - [ ] add client integration tests - [ ] add documentatio - [ ] add note and plan on the missing feature(s) i.e. secret mounts (that need tmpfs) - [ ] spec out / second attempt for SSH mount Fixes moby#5603 Signed-off-by: Anthony Nandaa <[email protected]>
Currently, mounts are not supported for WCOW builds, see moby#5678. This commit introduces support for bind and cache mounts. The remaining two require a little more work and consultation with the platform teams for enlightment. WIP Checklist: - [x] Support for bind mounts - [x] Support for cache mounts - [x] add frontend/dockerfile integration tests - [ ] add client integration tests - [ ] add documentatio - [ ] add note and plan on the missing feature(s) i.e. secret mounts (that need tmpfs) - [ ] spec out / second attempt for SSH mount Fixes moby#5603 Signed-off-by: Anthony Nandaa <[email protected]>
Currently, mounts are not supported for WCOW builds, see moby#5678. This commit introduces support for bind and cache mounts. The remaining two require a little more work and consultation with the platform teams for enlightment. WIP Checklist: - [x] Support for bind mounts - [x] Support for cache mounts - [x] add frontend/dockerfile integration tests - [ ] add client integration tests - [ ] add documentation Fixes moby#5603 Signed-off-by: Anthony Nandaa <[email protected]>
Currently, mounts are not supported for WCOW builds, see moby#5678. This commit introduces support for bind and cache mounts. The remaining two require a little more work and consultation with the platform teams for enlightment. WIP Checklist: - [x] Support for bind mounts - [x] Support for cache mounts - [x] add frontend/dockerfile integration tests - [x] add client integration tests (not all, `llb.AddMount` not complete) Fixes moby#5603 Signed-off-by: Anthony Nandaa <[email protected]>
Currently, mounts are not supported for WCOW builds, see moby#5678. This commit introduces support for bind and cache mounts. The remaining two require a little more work and consultation with the platform teams for enlightment. WIP Checklist: - [x] Support for bind mounts - [x] Support for cache mounts - [x] add frontend/dockerfile integration tests - [x] add client integration tests (not all, `llb.AddMount` not complete) Fixes moby#5603 Signed-off-by: Anthony Nandaa <[email protected]>
Currently, mounts are not supported for WCOW builds, see moby#5678. This commit introduces support for bind and cache mounts. The remaining two require a little more work and consultation with the platform teams for enlightment. WIP Checklist: - [x] Support for bind mounts - [x] Support for cache mounts - [x] add frontend/dockerfile integration tests - [x] add client integration tests (not all, `llb.AddMount` not complete) Fixes moby#5603 Signed-off-by: Anthony Nandaa <[email protected]>
Currently, mounts are not supported for WCOW builds, see moby#5678. This commit introduces support for bind and cache mounts. The remaining two require a little more work and consultation with the platform teams for enlightment. WIP Checklist: - [x] Support for bind mounts - [x] Support for cache mounts - [x] add frontend/dockerfile integration tests - [x] add client integration tests (not all, `llb.AddMount` not complete) Fixes moby#5603 Signed-off-by: Anthony Nandaa <[email protected]>
Currently, mounts are not supported for WCOW builds, see moby#5678. This commit introduces support for bind and cache mounts. The remaining two require a little more work and consultation with the platform teams for enlightment. WIP Checklist: - [x] Support for bind mounts - [x] Support for cache mounts - [x] add frontend/dockerfile integration tests - [x] add client integration tests (not all, `llb.AddMount` not complete) Fixes moby#5603 Signed-off-by: Anthony Nandaa <[email protected]>
Currently, mounts are not supported for WCOW builds, see moby#5678. This commit introduces support for bind and cache mounts. The remaining two require a little more work and consultation with the platform teams for enlightment. WIP Checklist: - [x] Support for bind mounts - [x] Support for cache mounts - [x] add frontend/dockerfile integration tests - [x] add client integration tests (not all, `llb.AddMount` not complete) Fixes moby#5603 Signed-off-by: Anthony Nandaa <[email protected]>
I have been doing some testing with windows container builds recently.
I have been trying to figure out it cache/bind mounts are supposed to work or not.
I have found this issue: #4837 Maybe the underlaying cause is the same even though the error message is different?
Environment
Windows Server 2022
Builkit 0.18.1
Containerd 1.7.24
Dockerfile
Output
Is this the expected result or have I possibly done something wrong?
The text was updated successfully, but these errors were encountered: