Repository navigation
Don't evaluate descriptors or import __main__.py during docstring collection - #79
Merged
Elias Freider (freider) merged 1 commit intoNov 4, 2026
Conversation
…lection Walk __dict__ like doctest.DocTestFinder instead of inspect.getmembers(), which calls every descriptor's __get__, and skip __main__.py the way pytest's doctest plugin does. Fixes modal-labs#76
Elias Freider (freider)
force-pushed
the
fix-docstring-collection-errors
branch
from
November 4, 2026 20:05
794e6ff to
7795650
Compare
Collaborator
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Docstring collection used
inspect.getmembers, which calls every descriptor's__get__, and it tried to import__main__.py, which clashes with the running pytest;--doctest-modulesdoes neither. This walks__dict__the wayDocTestFinderdoes (unwrapping staticmethod/classmethod) and skips__main__.py. Added tests for both;uv run pytest testspasses.Fixes #76