Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add sample for using Client Roots #5

Open
e5l opened this issue Dec 17, 2024 · 8 comments
Open

Add sample for using Client Roots #5

e5l opened this issue Dec 17, 2024 · 8 comments
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@e5l
Copy link
Contributor

e5l commented Dec 17, 2024

Describe the solution you'd like

Here is the spec: https://spec.modelcontextprotocol.io/specification/client/roots/

Upd link: https://modelcontextprotocol.io/docs/concepts/roots

@e5l e5l added the enhancement New feature or request label Dec 17, 2024
@e5l e5l added the good first issue Good for newcomers label Jan 7, 2025
@SeanChinJunKai
Copy link

@e5l I would like to work on this issue however im unable to access the link

@e5l
Copy link
Contributor Author

e5l commented Mar 28, 2025

Hey, thank you! It would be great 👍

It looks like the link has changed, I also don't have access. 🙂
Here is the updated link: https://modelcontextprotocol.io/docs/concepts/roots

@SeanChinJunKai
Copy link

SeanChinJunKai commented Mar 28, 2025

Thank you @e5l. Ill read up on this first

@SeanChinJunKai
Copy link

SeanChinJunKai commented Mar 29, 2025

@e5l Can I clarify that for this task i should be adding on to the kotlin-mcp-client in the samples folder?

@e5l
Copy link
Contributor Author

e5l commented Mar 29, 2025

Yep!

@SeanChinJunKai
Copy link

@e5l Thank you for the clarification. Ill take some time to digest the code and try setting up and then make the change.

@SeanChinJunKai
Copy link

SeanChinJunKai commented Mar 29, 2025

@e5l I think this are the changes required please correct me if I am wrong:

  1. Create a data class called Root and include validation for uri
    @serializable
    data class Root(
    val name: String,
    val uri: String
    )

  2. Modify Roots to include an array/list of Root

  3. Modify the kotlin-mcp-client sample to declare some sample roots

@e5l
Copy link
Contributor Author

e5l commented Mar 31, 2025

it also would be nice to show how to consume exposed roots

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

2 participants