Fixing review comments from CodeRabbit

* .github/workflows/build-fmus.yml: also trigger builds on push to main (not just tags/PRs).
* reference-FMUs/CMakeLists.txt: package the FMI headers into sources/ (so the FMU is rebuildable), pre-create build dirs.
* reference-FMUs/SimpleDAE/README.md: fixed the documented output path for the built FMU.
* reference-FMUs/SimpleDAE/config.h: dropped GET_PARTIAL_DERIVATIVE.
* reference-FMUs/SimpleDAE/fmi-ls-manifest.xml: schemaLocation now points at the GitHub-hosted schema instead of a local relative path.
* reference-FMUs/SimpleDAE/model.c: removed the dead getPartialDerivative stub that returned OK without setting the output.
* reference-FMUs/SimpleDAE/modelDescription.xml: providesDirectionalDerivatives/providesAdjointDerivatives now false, matching actual (non-)support.

Author: AnHeuermann

.github/workflows/build-fmus.yml

@@ -2,6 +2,7 @@ name: Build and test reference FMUs
 
 on:
   push:
+    branches: [ main ]
     tags:
       - '*'
   pull_request:

reference-FMUs/CMakeLists.txt

@@ -72,6 +72,10 @@ add_library(${MODEL_NAME} SHARED
   ${MODEL_NAME}/buildDescription.xml
 )
 
+if (UNIX AND NOT APPLE)
+  target_link_libraries(${MODEL_NAME} PRIVATE m)
+endif ()
+
 file(MAKE_DIRECTORY ${CMAKE_CURRENT_BINARY_DIR}/fmus)
 
 target_compile_definitions(${MODEL_NAME} PRIVATE
@@ -99,6 +103,10 @@ target_include_directories(${MODEL_NAME} PRIVATE
 )
 
 set(FMU_BUILD_DIR temp/${MODEL_NAME})
+file(MAKE_DIRECTORY
+  "${FMU_BUILD_DIR}/sources"
+  "${FMU_BUILD_DIR}/extra/org.fmi-standard.fmi-ls-dae"
+)
 
 set_target_properties(${MODEL_NAME} PROPERTIES
   RUNTIME_OUTPUT_DIRECTORY         "${FMU_BUILD_DIR}/binaries/${FMI_PLATFORM}"
@@ -131,7 +139,7 @@ foreach (SOURCE_FILE config.h model.c)
 endforeach ()
 
 # shared headers
-foreach (SOURCE_FILE model.h)
+foreach (SOURCE_FILE model.h fmi3Functions.h fmi3FunctionTypes.h fmi3PlatformTypes.h)
   add_custom_command(TARGET ${MODEL_NAME} POST_BUILD
     COMMAND ${CMAKE_COMMAND} -E copy
       "${CMAKE_CURRENT_SOURCE_DIR}/include/${SOURCE_FILE}"

reference-FMUs/SimpleDAE/README.md

@@ -51,7 +51,7 @@ cmake -B build
 cmake --build build --config Release
 ```
 
-The FMU is written to `build/cmake/fmus/SimpleDAE.fmu`.
+The FMU is written to `build/fmus/SimpleDAE.fmu`.
 
 By default CMake detects the host architecture. To cross-compile, pass `-DFMI_ARCHITECTURE=<arch>` where `<arch>` is one of `x86_64` or `aarch64`.
 

reference-FMUs/SimpleDAE/config.h

@@ -13,7 +13,6 @@
 #define SET_FLOAT64
 #define GET_BOOLEAN
 #define SET_BOOLEAN
-#define GET_PARTIAL_DERIVATIVE
 
 #define FIXED_SOLVER_STEP 1e-2
 #define DEFAULT_STOP_TIME 20

reference-FMUs/SimpleDAE/fmi-ls-manifest.xml

@@ -1,7 +1,7 @@
 <?xml version="1.0" encoding="UTF-8"?>
 <fmi-ls-dae
   xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
-  xsi:schemaLocation="http://fmi-standard.org/fmi-ls-manifest ../../schema/fmi3LayeredStandardDaeManifest.xsd"
+  xsi:schemaLocation="http://fmi-standard.org/fmi-ls-manifest https://raw.githubusercontent.com/modelica/fmi-ls-dae/main/schema/fmi3LayeredStandardDaeManifest.xsd"
   xmlns="http://fmi-standard.org/fmi-ls-manifest"
   xmlns:fmi-ls="http://fmi-standard.org/fmi-ls-manifest"
   fmi-ls:fmi-ls-name="org.fmi-standard.fmi-ls-dae"

reference-FMUs/SimpleDAE/model.c

@@ -134,36 +134,6 @@ Status getDerivatives(ModelInstance *comp, double dx[], size_t nx) {
     return OK;
 }
 
-Status getPartialDerivative(ModelInstance *comp, ValueReference unknown, ValueReference known, double *partialDerivative) {
-    UNUSED(comp);
-    UNUSED(unknown);
-    UNUSED(known);
-    UNUSED(partialDerivative);
-
-    if (M(ode_dae)) {
-
-    }
-    else {
-
-    }
-
-    /*if (unknown == vr_der_x1 && known == vr_x1) {
-        *partialDerivative = 0;
-    } else if (unknown == vr_der_x1 && known == vr_x2) {
-        *partialDerivative = 1;
-    } else if (unknown == vr_der_x2 && known == vr_x1) {
-        *partialDerivative = -2 * M(x1) * M(x2) * M(mu) - 1;
-    } else if (unknown == vr_der_x2 && known == vr_x2) {
-        *partialDerivative = M(mu) * (1 - M(x1) * M(x1));
-    } else if (unknown == vr_der_x2 && known == vr_mu && comp->state == InitializationMode) {
-        *partialDerivative = (1 - M(x1) * M(x1)) * M(x2);
-    } else {
-        *partialDerivative = 0;
-    }
-    */
-    return OK;
-}
-
 Status eventUpdate(ModelInstance *comp) {
 
     comp->valuesOfContinuousStatesChanged   = false;

reference-FMUs/SimpleDAE/modelDescription.xml

@@ -12,8 +12,8 @@
     modelIdentifier="SimpleDAE"
     canGetAndSetFMUState="true"
     canSerializeFMUState="true"
-    providesDirectionalDerivatives="true"
-    providesAdjointDerivatives="true" />
+    providesDirectionalDerivatives="false"
+    providesAdjointDerivatives="false" />
 
   <LogCategories>
     <Category name="logEvents" description="Log events" />