Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JAVA_TOOL_OPTIONS environment is passed down to Java #2422

Open
3 tasks done
brawaru opened this issue Sep 18, 2024 · 0 comments
Open
3 tasks done

JAVA_TOOL_OPTIONS environment is passed down to Java #2422

brawaru opened this issue Sep 18, 2024 · 0 comments
Labels
app Relates to Modrinth App bug Something isn't working

Comments

@brawaru
Copy link
Contributor

brawaru commented Sep 18, 2024

Please confirm the following.

  • I checked the existing issues for duplicate problems
  • I have tried resolving the issue using the support portal
  • I have ensured my Modrinth App installation is up to date

What version of the Modrinth App are you using?

0.8.7

What operating systems are you seeing the problem on?

Windows

Describe the bug

The app seems to pass down JAVA_TOOL_OPTIONS environment variable down when launching Java, which can cause issues similar to ones we had with _JAVA_OPTIONS environment variable when it has invalid values, like

  • being unable to complete installation of recommended Java because
  • being unable to install any modpack or create a new instance
  • Java tests failing
  • game not launching properly

Steps to reproduce

  1. Open command prompt.
  2. Execute SET JAVA_TOOL_OPTIONS=-XmxBananzaM -x:meowmeow.
  3. Drag Modrinth App executable into the window to insert its path and execute it as well.
  4. Test Java option in settings / Try installing recommended Java / Try creating a new modded instance.

(or otherwise define JAVA_TOOL_OPTIONS environment variable before launching Modrinth App and attempting step 4).

Expected behavior

The option is removed when Java is launched anywhere, similar to JAVA_OPTIONS, so it doesn't cause any issues.

Additional context

No response

@brawaru brawaru added app Relates to Modrinth App bug Something isn't working labels Sep 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
app Relates to Modrinth App bug Something isn't working
Development

No branches or pull requests

1 participant