It immediately crashes

[johnfn]

This is literally the first thing I did after I installed it.

 % stack-pr view
Exitcode: 128
Stdout: None
Stderr: fatal: Not a valid object name origin/main

Traceback (most recent call last):
  File "/Users/grantmathews/.local/bin/stack-pr", line 8, in <module>
    sys.exit(main())
             ~~~~^^
  File "/Users/grantmathews/.local/pipx/venvs/stack-pr/lib/python3.13/site-packages/stack_pr/cli.py", line 1403, in main
    common_args = deduce_base(common_args)
  File "/Users/grantmathews/.local/pipx/venvs/stack-pr/lib/python3.13/site-packages/stack_pr/cli.py", line 851, in deduce_base
    deduced_base = get_command_output(
        ["git", "merge-base", args.head, f"{args.remote}/{args.target}"]
    )
  File "/Users/grantmathews/.local/pipx/venvs/stack-pr/lib/python3.13/site-packages/stack_pr/shell_commands.py", line 59, in get_command_output
    proc = run_shell_command(cmd, capture_output=True, quiet=False, **kwargs)
  File "/Users/grantmathews/.local/pipx/venvs/stack-pr/lib/python3.13/site-packages/stack_pr/shell_commands.py", line 40, in run_shell_command
    return subprocess.run(list(map(str, cmd)), **kwargs)
           ~~~~~~~~~~~~~~^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/opt/homebrew/Cellar/python@3.13/3.13.2/Frameworks/Python.framework/Versions/3.13/lib/python3.13/subprocess.py", line 579, in run
    raise CalledProcessError(retcode, process.args,
                             output=stdout, stderr=stderr)
subprocess.CalledProcessError: Command '['git', 'merge-base', 'HEAD', 'origin/main']' returned non-zero exit status 128.

[AdityaKhowalGithub]

im getting thi too

[johnfn]

The reason this happens is because you likely named your main branch master, not main as this tool expects. The fix is this:

stack-pr view --target=master

A similar issue was closed, though I don't understand why. #46

[ZolotukhinM]

I agree that we can provide a better error message for this popular case. Strictly speaking, however, this is a user error (which is why the original issue was closed) - the default value points to a non-existent branch and no custom value was provided. But as I said earlier I agree it would be much friendlier to catch and handle this case better, as this is probably one of the first interactions with the tool.

[srikary12]

Will take this up and modify error logs to pop a better message.

[johnfn]

I'm not trying to be a jerk and I appreciate that you've provided this great tool for me to use. That being said, it's definitely not user error if the most basic use of the tool crashes with a stack trace on a completely ordinary repo. Can you imagine if I downloaded Skyrim and tried to play it and it crashed, but the devs said that was user error because I needed to go edit some text file somewhere?! :P

[AdityaKhowalGithub]

Does it default not to main or master??

[ZolotukhinM]

It defaults to main and produces an error reported here if your branch is master (instead of main). It fails to find the branch it defaults to (main), and the user can fix that by either changing the default or specifying the branch name directly.