fix(enhanced): apply getPublicPath only if exposes is set (#3717)

Author: 2heal1

.changeset/dull-buttons-sneeze.md

@@ -0,0 +1,6 @@
+---
+'@module-federation/enhanced': patch
+'@module-federation/rspack': patch
+---
+
+fix(enhanced): apply getPublicPath only if exposes is set

packages/enhanced/src/lib/container/ModuleFederationPlugin.ts

@@ -79,12 +79,10 @@ class ModuleFederationPlugin implements WebpackPluginInstance {
   apply(compiler: Compiler): void {
     const { _options: options } = this;
     // must before ModuleFederationPlugin
-    if (options.getPublicPath && options.name) {
-      new RemoteEntryPlugin(options.name, options.getPublicPath).apply(
-        // @ts-ignore
-        compiler,
-      );
-    }
+    new RemoteEntryPlugin(options).apply(
+      // @ts-ignore
+      compiler,
+    );
     if (options.experiments?.provideExternalRuntime) {
       if (options.exposes) {
         throw new Error(

packages/rspack/src/ModuleFederationPlugin.ts

@@ -77,11 +77,7 @@ export class ModuleFederationPlugin implements RspackPluginInstance {
     }
 
     // must before ModuleFederationPlugin
-    if (options.getPublicPath && options.name) {
-      new RemoteEntryPlugin(options.name, options.getPublicPath).apply(
-        compiler,
-      );
-    }
+    new RemoteEntryPlugin(options).apply(compiler);
 
     if (options.experiments?.provideExternalRuntime) {
       if (options.exposes) {

packages/rspack/src/RemoteEntryPlugin.ts

@@ -1,6 +1,10 @@
+import pBtoa from 'btoa';
+import { ContainerManager } from '@module-federation/managers';
+import logger from './logger';
+
 import type { Compiler, RspackPluginInstance } from '@rspack/core';
+import type { moduleFederationPlugin } from '@module-federation/sdk';
 // @ts-ignore
-import pBtoa from 'btoa';
 
 const charMap: Record<string, string> = {
   '<': '\\u003C',
@@ -23,19 +27,29 @@ function escapeUnsafeChars(str: string) {
 
 export class RemoteEntryPlugin implements RspackPluginInstance {
   readonly name = 'VmokRemoteEntryPlugin';
-  private _name: string;
-  private _getPublicPath: string;
+  _options: moduleFederationPlugin.ModuleFederationPluginOptions;
 
-  constructor(name: string, getPublicPath: string) {
-    this._name = name;
-    this._getPublicPath = getPublicPath;
+  constructor(options: moduleFederationPlugin.ModuleFederationPluginOptions) {
+    this._options = options;
   }
 
   apply(compiler: Compiler): void {
+    const { name, getPublicPath } = this._options;
+    if (!getPublicPath || !name) {
+      return;
+    }
+    const containerManager = new ContainerManager();
+    containerManager.init(this._options);
+    if (!containerManager.enable) {
+      logger.warn(
+        "Detect you don't set exposes, 'getPublicPath' will not have effect.",
+      );
+      return;
+    }
     let code;
-    const sanitizedPublicPath = escapeUnsafeChars(this._getPublicPath);
+    const sanitizedPublicPath = escapeUnsafeChars(getPublicPath);
 
-    if (!this._getPublicPath.startsWith('function')) {
+    if (!getPublicPath.startsWith('function')) {
       code = `${
         compiler.webpack.RuntimeGlobals.publicPath
       } = new Function(${JSON.stringify(sanitizedPublicPath)})()`;
@@ -47,7 +61,7 @@ export class RemoteEntryPlugin implements RspackPluginInstance {
 
     compiler.hooks.afterPlugins.tap('VmokRemoteEntryPlugin', () => {
       new compiler.webpack.EntryPlugin(compiler.context, dataUrl, {
-        name: this._name,
+        name: name,
       }).apply(compiler);
     });
   }

packages/rspack/src/logger.ts

@@ -0,0 +1,5 @@
+import { createLogger } from '@module-federation/sdk';
+
+const logger = createLogger('[ Module Federation Rspack Plugin ]');
+
+export default logger;