From e7ce513ed70f0e05ede617dfb142e28ee30fa8f9 Mon Sep 17 00:00:00 2001 From: Ben March Date: Thu, 25 Jul 2024 17:07:05 -0400 Subject: [PATCH 1/2] fix(runtime): ensured attributes are forwarded to createScript hook --- packages/runtime/src/utils/preload.ts | 9 ++++++--- 1 file changed, 6 insertions(+), 3 deletions(-) diff --git a/packages/runtime/src/utils/preload.ts b/packages/runtime/src/utils/preload.ts index 09ce000c438..7a4eb429022 100644 --- a/packages/runtime/src/utils/preload.ts +++ b/packages/runtime/src/utils/preload.ts @@ -82,9 +82,10 @@ export function preloadAssets( getRemoteEntry({ remoteInfo: moduleInfo, remoteEntryExports: module.remoteEntryExports, - createScriptHook: (url: string) => { + createScriptHook: (url: string, attrs: any) => { const res = host.loaderHook.lifecycle.createScript.emit({ url, + attrs, }); if (!res) return; @@ -108,9 +109,10 @@ export function preloadAssets( getRemoteEntry({ remoteInfo: moduleInfo, remoteEntryExports: undefined, - createScriptHook: (url: string) => { + createScriptHook: (url: string, attrs: any) => { const res = host.loaderHook.lifecycle.createScript.emit({ url, + attrs, }); if (!res) return; @@ -211,9 +213,10 @@ export function preloadAssets( attrs: { fetchpriority: 'high', }, - createScriptHook: (url: string) => { + createScriptHook: (url: string, attrs: any) => { const res = host.loaderHook.lifecycle.createScript.emit({ url, + attrs, }); if (res instanceof HTMLScriptElement) { return res; From 68f9b71180ebaa5cbaa8c274a5c4035b89759b70 Mon Sep 17 00:00:00 2001 From: Ben March Date: Thu, 25 Jul 2024 17:47:47 -0400 Subject: [PATCH 2/2] fix(runtime): ensured attributes are forwarded to createScript hook --- .changeset/good-shirts-cover.md | 5 +++++ 1 file changed, 5 insertions(+) create mode 100644 .changeset/good-shirts-cover.md diff --git a/.changeset/good-shirts-cover.md b/.changeset/good-shirts-cover.md new file mode 100644 index 00000000000..887fa295d21 --- /dev/null +++ b/.changeset/good-shirts-cover.md @@ -0,0 +1,5 @@ +--- +'@module-federation/runtime': patch +--- + +Ensured createScript runtime hook always receives `attrs`