Skip to content

Commit 4a3ff29

Browse files
aherlihyimlucas
authored andcommitted
COMPASS-341 - Hide intercom widget when feedback disabled (#656)
1 parent 90dba3e commit 4a3ff29

File tree

2 files changed

+11
-4
lines changed

2 files changed

+11
-4
lines changed

src/app/metrics/index.js

Lines changed: 9 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -102,13 +102,20 @@ module.exports = function() {
102102
// enable/disable event tracking
103103
metrics.trackers.get('ga').enabled = enabled;
104104
metrics.trackers.get('intercom').enabled = enabled;
105+
if (enabled && !app.preferences.enableFeedbackPanel) {
106+
document.querySelector('#intercom-container').classList.add('hidden');
107+
}
105108
// metrics.trackers.get('mixpanel').enabled = enabled;
106109
});
107110
app.preferences.on('change:enableFeedbackPanel', function(prefs, enabled) {
108111
// enable/disable product feedback
109112
metrics.trackers.get('intercom').panelEnabled = enabled;
110-
if (!enabled && window.Intercom) {
111-
window.Intercom('hide');
113+
if (Window && document.querySelector('#intercom-container')) {
114+
if (enabled) {
115+
document.querySelector('#intercom-container').classList.remove('hidden');
116+
} else {
117+
document.querySelector('#intercom-container').classList.add('hidden');
118+
}
112119
}
113120
});
114121
app.preferences.on('change:trackErrors', function(prefs, enabled) {

src/app/metrics/intercom.js

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -19,8 +19,8 @@ module.exports.configure = function() {
1919
// open intercom panel when user chooses it from menu
2020
ipc.on('window:show-intercom-panel', function() {
2121
/* eslint new-cap: 0 */
22-
if (window.Intercom && app.preferences.enableFeedbackPanel) {
23-
window.Intercom('show');
22+
if (window.Intercom && app.preferences.enableFeedbackPanel && app.preferences.trackUsageStatistics) {
23+
document.querySelector('#intercom-container').classList.remove('hidden');
2424
metrics.track('Intercom Panel', 'used');
2525
}
2626
});

0 commit comments

Comments
 (0)