PHPLARA-259 Add connection-level maxTimeMS defaults (#3571)

Author: GromNaN

src/Query/Builder.php

@@ -447,10 +447,6 @@ public function toMql(): array
         $options = [];
 
         // Apply order, offset, limit and projection
-        if ($this->timeout) {
-            $options['maxTimeMS'] = (int) ($this->timeout * 1000);
-        }
-
         if ($this->orders) {
             $options['sort'] = $this->grammar->prepareFieldsForQuery($this->orders);
         }
@@ -1778,6 +1774,12 @@ private static function vectorSearchSupportsAutoEmbedding(): bool
      */
     private function inheritConnectionOptions(array $options = []): array
     {
+        $queryTimeout = $this->timeout ? (int) ($this->timeout * 1000) : $this->connection->getConfig('options.maxTimeMS');
+
+        if ($queryTimeout !== null) {
+            $options['maxTimeMS'] ??= (int) $queryTimeout;
+        }
+
         if (! isset($options['session'])) {
             $session = $this->connection->getSession();
             if ($session) {

tests/Query/BuilderTest.php

@@ -9,6 +9,7 @@
 use Closure;
 use DateTimeImmutable;
 use Illuminate\Database\Eloquent\Collection;
+use Illuminate\Support\Arr;
 use Illuminate\Tests\Database\DatabaseQueryBuilderTest;
 use InvalidArgumentException;
 use LogicException;
@@ -57,6 +58,24 @@ public function testMql(array $expected, Closure $build, ?string $requiredMethod
         $this->assertEquals($expected, $mql, var_export($mql, true));
     }
 
+    #[DataProvider('provideConnectionOptions')]
+    public function testConnectionOptionsAreInheritedByMql(array $expected, Closure $build, array $config): void
+    {
+        $builder = $build($this->getBuilder(true, $config));
+        $this->assertInstanceOf(Builder::class, $builder);
+        $mql = $builder->toMql();
+
+        if (isset($expected['find'][1])) {
+            $expected['find'][1]['typeMap'] = ['root' => 'object', 'document' => 'array'];
+        }
+
+        if (isset($expected['aggregate'][1])) {
+            $expected['aggregate'][1]['typeMap'] = ['root' => 'object', 'document' => 'array'];
+        }
+
+        $this->assertEquals($expected, $mql, var_export($mql, true));
+    }
+
     public static function provideQueryBuilderToMql(): iterable
     {
         /**
@@ -1769,10 +1788,57 @@ public function prepareFieldsForQuery(array $values, bool $root = true): array
         );
     }
 
-    private function getBuilder(bool $renameEmbeddedIdField = true): Builder
+    public static function provideConnectionOptions(): iterable
+    {
+        yield 'find inherits maxTimeMS from config' => [
+            ['find' => [[], ['maxTimeMS' => 2000]]],
+            fn (Builder $builder) => $builder,
+            ['options' => ['maxTimeMS' => 2000]],
+        ];
+
+        yield 'aggregate inherits maxTimeMS from config' => [
+            [
+                'aggregate' => [
+                    [['$group' => ['_id' => ['foo' => '$foo'], 'foo' => ['$last' => '$foo']]]],
+                    ['maxTimeMS' => 2000],
+                ],
+            ],
+            fn (Builder $builder) => $builder->groupBy('foo'),
+            ['options' => ['maxTimeMS' => 2000]],
+        ];
+
+        yield 'distinct inherits maxTimeMS from config' => [
+            ['distinct' => ['foo', [], ['maxTimeMS' => 2000]]],
+            fn (Builder $builder) => $builder->distinct('foo'),
+            ['options' => ['maxTimeMS' => 2000]],
+        ];
+
+        yield 'options maxTimeMS overrides config maxTimeMS' => [
+            ['find' => [[], ['maxTimeMS' => 5000]]],
+            fn (Builder $builder) => $builder->options(['maxTimeMS' => 5000]),
+            ['options' => ['maxTimeMS' => 2000]],
+        ];
+
+        yield 'timeout overrides config maxTimeMS' => [
+            ['find' => [[], ['maxTimeMS' => 1000]]],
+            fn (Builder $builder) => $builder->timeout(1),
+            ['options' => ['maxTimeMS' => 2000]],
+        ];
+
+        yield 'empty config does not inject maxTimeMS' => [
+            ['find' => [[], []]],
+            fn (Builder $builder) => $builder,
+            [],
+        ];
+    }
+
+    private function getBuilder(bool $renameEmbeddedIdField = true, array $config = []): Builder
     {
         $connection = $this->createStub(Connection::class);
         $connection->method('getRenameEmbeddedIdField')->willReturn($renameEmbeddedIdField);
+        $connection->method('getConfig')->willReturnCallback(
+            static fn (?string $key = null): mixed => Arr::get($config, $key),
+        );
         $processor  = $this->createStub(Processor::class);
         $connection->method('getSession')->willReturn(null);
         $connection->method('getQueryGrammar')->willReturn(new Grammar($connection));