Fix PHP 8.5 deprecations of (integer), (long) and (boolean) casts (#1758)

* build(deps-dev): updated rector/rector to ^2.1.4

* chore: fix PHP 8.5 deprecations.

Author: mickverm

composer.json

@@ -18,7 +18,7 @@
     "require-dev": {
         "doctrine/coding-standard": "^12.0",
         "phpunit/phpunit": "^10.5.35",
-        "rector/rector": "^1.2",
+        "rector/rector": "^2.1.4",
         "squizlabs/php_codesniffer": "^3.7",
         "vimeo/psalm": "6.5.*"
     },

rector.php

@@ -1,42 +1,47 @@
 <?php
 
+use PhpParser\Node\Expr\Cast\Bool_;
+use PhpParser\Node\Expr\Cast\Double;
+use PhpParser\Node\Expr\Cast\Int_;
 use Rector\Config\RectorConfig;
 use Rector\DeadCode\Rector\ClassLike\RemoveAnnotationRector;
 use Rector\Php70\Rector\StmtsAwareInterface\IfIssetToCoalescingRector;
 use Rector\Php71\Rector\FuncCall\RemoveExtraParametersRector;
 use Rector\Php80\Rector\Switch_\ChangeSwitchToMatchRector;
-use Rector\PHPUnit\PHPUnit100\Rector\Class_\StaticDataProviderClassMethodRector;
-use Rector\PHPUnit\Set\PHPUnitSetList;
-use Rector\Set\ValueObject\LevelSetList;
+use Rector\Renaming\Rector\Cast\RenameCastRector;
+use Rector\Renaming\ValueObject\RenameCast;
 
-return static function (RectorConfig $rectorConfig): void {
-    $rectorConfig->paths([
+return RectorConfig::configure()
+    ->withPaths([
         __DIR__ . '/examples',
         __DIR__ . '/src',
         __DIR__ . '/tests',
         __DIR__ . '/tools',
-    ]);
-
-    // Modernize code
-    $rectorConfig->sets([
-        LevelSetList::UP_TO_PHP_74,
-        PHPUnitSetList::PHPUNIT_100,
-    ]);
-
-    $rectorConfig->rule(ChangeSwitchToMatchRector::class);
-    $rectorConfig->rule(StaticDataProviderClassMethodRector::class);
-
+    ])
+    ->withPhpSets(php74: true)
+    ->withComposerBased(phpunit: true)
+    ->withRules([
+        ChangeSwitchToMatchRector::class,
+    ])
+    // All classes are public API by default, unless marked with @internal.
+    ->withConfiguredRule(RemoveAnnotationRector::class, ['api'])
+    // Fix PHP 8.5 deprecations
+    ->withConfiguredRule(
+        RenameCastRector::class,
+        [
+            new RenameCast(Int_::class, Int_::KIND_INTEGER, Int_::KIND_INT),
+            new RenameCast(Bool_::class, Bool_::KIND_BOOLEAN, Bool_::KIND_BOOL),
+            new RenameCast(Double::class, Double::KIND_DOUBLE, Double::KIND_FLOAT),
+        ],
+    )
     // phpcs:disable Squiz.Arrays.ArrayDeclaration.KeySpecified
-    $rectorConfig->skip([
+    ->withSkip([
         RemoveExtraParametersRector::class,
         // Do not use ternaries extensively
         IfIssetToCoalescingRector::class,
         ChangeSwitchToMatchRector::class => [
             __DIR__ . '/tests/SpecTests/Operation.php',
         ],
-    ]);
+    ])
     // phpcs:enable
-
-    // All classes are public API by default, unless marked with @internal.
-    $rectorConfig->ruleWithConfiguration(RemoveAnnotationRector::class, ['api']);
-};
+    ->withImportNames(importNames: false, removeUnusedImports: true);

src/GridFS/Bucket.php

@@ -35,7 +35,6 @@
 use MongoDB\GridFS\Exception\StreamException;
 use MongoDB\Model\BSONArray;
 use MongoDB\Model\BSONDocument;
-use MongoDB\Operation\Find;
 
 use function array_intersect_key;
 use function array_key_exists;

src/GridFS/ReadableStream.php

@@ -82,7 +82,7 @@ public function __construct(private CollectionWrapper $collectionWrapper, privat
         $this->length = $file->length;
 
         if ($this->length > 0) {
-            $this->numChunks = (integer) ceil($this->length / $this->chunkSize);
+            $this->numChunks = (int) ceil($this->length / $this->chunkSize);
             $this->expectedLastChunkSize = $this->length - (($this->numChunks - 1) * $this->chunkSize);
         }
     }
@@ -184,7 +184,7 @@ public function seek(int $offset): void
          * changed, we'll also need to reset the buffer.
          */
         $lastChunkOffset = $this->chunkOffset;
-        $this->chunkOffset = (integer) floor($offset / $this->chunkSize);
+        $this->chunkOffset = (int) floor($offset / $this->chunkSize);
         $this->bufferOffset = $offset % $this->chunkSize;
 
         if ($lastChunkOffset === $this->chunkOffset) {

src/MapReduceResult.php

@@ -104,7 +104,7 @@ public function getTiming()
     public function __construct(callable $getIterator, stdClass $result)
     {
         $this->getIterator = $getIterator;
-        $this->executionTimeMS = isset($result->timeMillis) ? (integer) $result->timeMillis : 0;
+        $this->executionTimeMS = isset($result->timeMillis) ? (int) $result->timeMillis : 0;
         $this->counts = isset($result->counts) ? (array) $result->counts : [];
         $this->timing = isset($result->timing) ? (array) $result->timing : [];
     }

src/Model/CollectionInfo.php

@@ -62,7 +62,7 @@ public function __debugInfo()
     public function getCappedMax()
     {
         /* The MongoDB server might return this number as an integer or float */
-        return isset($this->info['options']['max']) ? (integer) $this->info['options']['max'] : null;
+        return isset($this->info['options']['max']) ? (int) $this->info['options']['max'] : null;
     }
 
     /**
@@ -75,7 +75,7 @@ public function getCappedMax()
     public function getCappedSize()
     {
         /* The MongoDB server might return this number as an integer or float */
-        return isset($this->info['options']['size']) ? (integer) $this->info['options']['size'] : null;
+        return isset($this->info['options']['size']) ? (int) $this->info['options']['size'] : null;
     }
 
     /**

src/Model/DatabaseInfo.php

@@ -69,7 +69,7 @@ public function getName()
     public function getSizeOnDisk()
     {
         /* The MongoDB server might return this number as an integer or float */
-        return (integer) $this->info['sizeOnDisk'];
+        return (int) $this->info['sizeOnDisk'];
     }
 
     /**
@@ -79,7 +79,7 @@ public function getSizeOnDisk()
      */
     public function isEmpty()
     {
-        return (boolean) $this->info['empty'];
+        return (bool) $this->info['empty'];
     }
 
     /**

src/Model/IndexInfo.php

@@ -111,7 +111,7 @@ public function getNamespace()
      */
     public function getVersion()
     {
-        return (integer) $this->info['v'];
+        return (int) $this->info['v'];
     }
 
     /**

src/Operation/Count.php

@@ -147,7 +147,7 @@ public function execute(Server $server)
             throw new UnexpectedValueException('count command did not return a numeric "n" value');
         }
 
-        return (integer) $result->n;
+        return (int) $result->n;
     }
 
     /**

src/Operation/CountDocuments.php

@@ -128,7 +128,7 @@ public function execute(Server $server)
             throw new UnexpectedValueException('count command did not return a numeric "n" value');
         }
 
-        return (integer) $result->n;
+        return (int) $result->n;
     }
 
     private function createAggregate(): Aggregate