Refactor unit-tests

Author: lsierant

.dockerignore

@@ -8,7 +8,7 @@
 vendor/
 pkg/client/
 docker/mongodb-kubernetes-tests
-scripts/
+# scripts/
 samples/
 .multi_cluster_local_test_files/
 

.evergreen-functions.yml

@@ -669,12 +669,9 @@ functions:
       params:
         shell: bash
         working_dir: src/github.com/mongodb/mongodb-kubernetes
-        script: |
-          source .generated/context.export.env
-          make test-race
-    - command: gotest.parse_files
-      params:
-        files: [ "src/github.com/mongodb/mongodb-kubernetes/*.suite", "src/github.com/mongodb/mongodb-kubernetes/docker/mongodb-kubernetes-init-ops-manager/mmsconfiguration/*.suite" ]
+        env:
+          USE_RACE: "true"
+        script: scripts/evergreen/unit-tests-golang.sh
 
   test_helm_unit:
     - command: shell.exec
@@ -692,19 +689,15 @@ functions:
       params:
         shell: bash
         working_dir: src/github.com/mongodb/mongodb-kubernetes
-        script: |
-          source .generated/context.export.env
-          make python-tests
+        script: scripts/evergreen/unit-tests-python.sh
 
-  test_sboms:
+  test_python_sbom:
     - command: shell.exec
       type: test
       params:
         shell: bash
         working_dir: src/github.com/mongodb/mongodb-kubernetes
-        script: |
-          source .generated/context.export.env
-          make sbom-tests
+        script: scripts/evergreen/unit-tests-sbom.sh
 
   generate_perf_tests_tasks:
     - *switch_context

.evergreen.yml

@@ -271,7 +271,7 @@ tasks:
     # See https://docs.devprod.prod.corp.mongodb.com/evergreen/Project-Configuration/Project-Configuration-Files#limiting-when-a-task-or-variant-will-run
     patchable: false
     commands:
-      - func: "test_sboms"
+      - func: "test_python_sbom"
 
   - name: lint_repo
     tags: [ "unit_tests" ]
@@ -566,6 +566,11 @@ task_groups:
       - unit_tests_python
       - unit_tests_helm
       - sbom_tests
+    teardown_task:
+      - command: attach.xunit_results
+        params:
+          files: [ "src/github.com/mongodb/mongodb-kubernetes/*-result.xml" ]
+
 
   # Task group for deploying mongodbcommunity resources and testing the (former) MCO
   - name: e2e_mdb_community_task_group

.gitignore

@@ -55,6 +55,7 @@ bundle
 .DS_Store
 cover.out
 result.suite
+*result.xml
 # loadtesting binary
 production_notes/cmd/runtest/runtest
 production_notes/helm_charts/opsmanager/charts/

Makefile

@@ -278,19 +278,18 @@ endif
 ENVTEST_ASSETS_DIR=$(shell pwd)/testbin
 
 golang-tests:
-	scripts/evergreen/unit-tests.sh
+	scripts/evergreen/unit-tests-golang.sh
 
 golang-tests-race:
-	USE_RACE=true scripts/evergreen/unit-tests.sh
+	USE_RACE=true scripts/evergreen/unit-tests-golang.sh
 
 sbom-tests:
-	@ scripts/dev/run_python.sh -m pytest generate_ssdlc_report_test.py
+	scripts/evergreen/unit-tests-sbom.sh
 
 # e2e tests are also in python and we will need to ignore them as they are in the docker/mongodb-kubernetes-tests folder
 # additionally, we have one lib which we want to test which is in the =docker/mongodb-kubernetes-tests folder.
 python-tests:
-	@ scripts/dev/run_python.sh -m pytest docker/mongodb-kubernetes-tests/kubeobject
-	@ scripts/dev/run_python.sh -m pytest --ignore=docker/mongodb-kubernetes-tests
+	scripts/evergreen/unit-tests-python.sh
 
 generate-ssdlc-report:
 	@ scripts/dev/run_python.sh generate_ssdlc_report.py

api/v1/mdb/sharded_cluster_validation_test.go

@@ -238,6 +238,10 @@ func TestNoIgnoredFieldUsed(t *testing.T) {
 			Spec: corev1.PodSpec{},
 		}},
 	}
+
+	// when tests are executed with env set from current context, some kubeconfig validation tests might stop working
+	t.Setenv(multicluster.KubeConfigPathEnv, "")
+
 	tests := []struct {
 		name              string
 		isMultiCluster    bool

controllers/operator/appdbreplicaset_controller_test.go

@@ -6,7 +6,6 @@ import (
 	"fmt"
 	"os"
 	"path/filepath"
-	"strings"
 	"testing"
 	"time"
 
@@ -54,15 +53,14 @@ func init() {
 
 // getReleaseJsonPath searches for a specified target directory by traversing the directory tree backwards from the current working directory
 func getReleaseJsonPath() (string, error) {
-	repositoryRootDirName := "mongodb-kubernetes"
 	releaseFileName := "release.json"
 
 	currentDir, err := os.Getwd()
 	if err != nil {
 		return "", err
 	}
 	for currentDir != "/" {
-		if strings.HasSuffix(currentDir, repositoryRootDirName) {
+		if _, err := os.Stat(filepath.Join(currentDir, releaseFileName)); err == nil {
 			return filepath.Join(currentDir, releaseFileName), nil
 		}
 		currentDir = filepath.Dir(currentDir)

docker/mongodb-kubernetes-init-ops-manager/go.mod

@@ -145,7 +145,7 @@ func readLinesFromFile(name string) ([]string, error) {
 func writeLinesToFile(name string, lines []string) error {
 	output := strings.Join(lines, lineBreak)
 
-	err := os.WriteFile(name, []byte(output), 0o644)
+	err := os.WriteFile(name, []byte(output), 0o644) // nolint:gosec
 	if err != nil {
 		return xerrors.Errorf("error writing to file %s: %w", name, err)
 	}