Skip to content

Commit 57cd020

Browse files
badboyrvandermeulen
andcommitted
Update AGP to v8.8.2
Co-Authored-By: Ryan VanderMeulen <rvandermeulen@mozilla.com>
1 parent 9626669 commit 57cd020

7 files changed

Lines changed: 19 additions & 13 deletions

File tree

CHANGELOG.md

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -9,6 +9,7 @@
99
* Updated Gradle to 8.13 ([#3074](https://github.com/mozilla/glean/pull/3080))
1010
* Updated to Android NDK 28 and SDK 35 ([#3074](https://github.com/mozilla/glean/pull/3080))
1111
* Updated Kotlin to version 2.1.10 ([#3074](https://github.com/mozilla/glean/pull/3080))
12+
* Updated Android Gradle Plugin to 8.8.2 ([#3074](https://github.com/mozilla/glean/pull/3080))
1213
* Rust
1314
* Report more desktop architectures in `client_info.architecture` ([bug 1944694](https://bugzilla.mozilla.org/show_bug.cgi?id=1944694))
1415

build.gradle

Lines changed: 0 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -120,19 +120,8 @@ subprojects {
120120

121121
// Kotlin settings applicable to all modules.
122122
afterEvaluate {
123-
if (it.hasProperty('android')) {
124-
android {
125-
// This shouldn't be needed anymore with AGP 8.1.0+
126-
// https://kotlinlang.org/docs/gradle-configure-project.html#gradle-java-toolchains-support
127-
compileOptions {
128-
sourceCompatibility rootProject.ext.build.jvmTargetCompatibility
129-
targetCompatibility rootProject.ext.build.jvmTargetCompatibility
130-
}
131-
}
132-
}
133123
tasks.withType(org.jetbrains.kotlin.gradle.tasks.KotlinCompile).all {
134124
kotlinOptions.allWarningsAsErrors = true
135-
kotlin.jvmToolchain(rootProject.ext.build.jvmTargetCompatibility)
136125
}
137126
}
138127

glean-core/android-native/build.gradle

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -8,8 +8,13 @@
88
import groovy.json.JsonOutput
99

1010
apply plugin: 'com.android.library'
11+
apply plugin: 'kotlin-android'
1112
apply plugin: 'org.mozilla.rust-android-gradle.rust-android'
1213

14+
kotlin {
15+
jvmToolchain(rootProject.ext.build.jvmTargetCompatibility)
16+
}
17+
1318
android {
1419
namespace "mozilla.telemetry.glean_native"
1520

glean-core/android/build.gradle

Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -28,6 +28,10 @@ File GLEAN_PING_SCHEMA_PATH = file("$rootDir/glean.1.schema.json")
2828
ext.allowGleanInternal = true
2929
ext.gleanNamespace = "mozilla.telemetry.glean"
3030

31+
kotlin {
32+
jvmToolchain(rootProject.ext.build.jvmTargetCompatibility)
33+
}
34+
3135
android {
3236
compileSdkVersion rootProject.ext.build.compileSdkVersion
3337
namespace "mozilla.telemetry.glean"
@@ -96,6 +100,10 @@ android {
96100
}
97101
}
98102

103+
kotlin {
104+
jvmToolchain(rootProject.ext.build.jvmTargetCompatibility)
105+
}
106+
99107
afterEvaluate {
100108
if (project.hasProperty("coverage")) {
101109
jacoco {

gradle.properties

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -23,4 +23,3 @@ libLicense=MPL-2.0
2323
libLicenseUrl=https://www.mozilla.org/en-US/MPL/2.0/
2424

2525
android.useAndroidX=true
26-
android.experimental.lint.version=8.3.0

gradle/libs.versions.toml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,7 @@
55

66
[versions]
77
# AGP
8-
android-plugin = "8.0.2"
8+
android-plugin = "8.8.2"
99

1010
# Kotlin
1111
kotlin-compiler = "2.1.10"

samples/android/app/build.gradle

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -10,6 +10,10 @@ apply plugin: 'com.android.application'
1010
apply plugin: 'kotlin-android'
1111
apply plugin: 'kotlinx-serialization'
1212

13+
kotlin {
14+
jvmToolchain(rootProject.ext.build.jvmTargetCompatibility)
15+
}
16+
1317
android {
1418
namespace "org.mozilla.samples.gleancore"
1519
compileSdkVersion rootProject.ext.build.compileSdkVersion

0 commit comments

Comments
 (0)