Implement ES2025 RegExp.escape static method #2183
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds support for RegExp.escape() which escapes special regex characters
in strings for safe use in regular expressions.
Implementation:
- Escapes syntax chars (.*+?^$|()[]{}\/) with backslash
- Escapes control chars (\t\n\v\f\r) with special sequences
- Escapes initial digits/letters with \xNN to prevent ambiguity
- Escapes surrogates with \uXXXX format
- Escapes other punctuators (,-=<>#&\!%:;@~'`") with \xNN
- Escapes whitespace and line terminators appropriately
- Throws TypeError for non-string inputs
Testing:
- 15 Java unit tests (all passing)
- test262: 19/20 tests passing (95% compliance)
- Manual verification confirms spec-compliant output
anivar
force-pushed
the
es2025-regexp-escape
branch
from
0149244 to
37218ff
Compare
RegExp test failures improved from 956 to 955 after rebasing on latest master.
gbrail
reviewed
Nov 30, 2025
Collaborator
gbrail
left a comment
gbrail
left a comment
There was a problem hiding this comment.
Please do a "DRY" check on that character classification code. Thanks!
| } | ||
|
|
||
| /** Check if character is a decimal digit (0-9) */ | ||
| private static boolean isDecimalDigit(char c) { |
Collaborator
There was a problem hiding this comment.
I'm sure that we already have implementations of these checks either elsewhere in the codebase, or in the Java Character class. Can you please check first to see if we can reuse those or make them more generic rather than encode this here? I won't be surprised if we need a few new ones but checks like isWhiteSpace and isDecimalDigit are certainly not unique to this method. Thanks!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements the ES2025 RegExp.escape() static method for safely escaping special regex characters in strings.
Implementation
Testing
Impact
Provides standardized, spec-compliant solution for escaping user input in regular expressions, improving code safety and developer experience.