Removed a test case about dates that uses the current instant #2188
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It's an inconsistent behavior that has caused a flaky test failure [in the CI](https://github.com/mozilla/rhino/actions/runs/19851039740/job/56877721100#step:5:278). I've only removed the test case with the "current instant", not the whole test, although really all of these seem kinda obsolete and superset by test262, frankly. They also contain JS implementation of date methods, like this [LocalTime]( https://github.com/mozilla/rhino/blob/e3d6b16aa233e0a427bf1dfe6b4ba3645213b924/tests/testsrc/tests/ecma/shell.js#L304) function, which are pretty complex. According to Claude at least, there's likely a discrepancy between the daylight savings time behavior, but I didn't investigate much further.
Contributor
Author
|
Apparently there are other tests flapping today, see https://github.com/mozilla/rhino/actions/runs/19864734129/job/56924144927?pr=2190 So I don't think this is a good solution. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's an inconsistent behavior that has caused a flaky test failure in the CI.
I've only removed the test case with the "current instant", not the whole test, although really all of these seem kinda obsolete and superset by test262, frankly. They also contain JS implementation of date methods, like this LocalTime function, which are pretty complex.
According to Claude at least, there's likely a discrepancy between the daylight savings time behavior, but I didn't investigate much further.
Fixes #2187