Skip to content

Commit 0f90824

Browse files
authored
Merge pull request #473 from mrmlnc/remove_bundling
Remove bundle stage
2 parents 7f28b15 + d533841 commit 0f90824

File tree

4 files changed

+25
-37
lines changed

4 files changed

+25
-37
lines changed

.github/CONTRIBUTING.md

-5
Original file line numberDiff line numberDiff line change
@@ -50,11 +50,6 @@ npm run test:e2e
5050
# Watch changes
5151
npm run watch
5252

53-
# Build bundle
54-
npm run bundle
55-
npm t
56-
npm run test:e2e
57-
5853
# Run benchmark
5954
npm run bench:async
6055
npm run bench:sync

.github/workflows/benchmark.yml

+15-15
Original file line numberDiff line numberDiff line change
@@ -22,14 +22,14 @@ jobs:
2222
node-version: 22
2323
- name: Install dependencies
2424
run: npm install
25-
- name: Prepare bundle
26-
run: npm run bundle
25+
- name: Build
26+
run: node --run build
2727
- name: Benchmark (async)
28-
run: npm run bench:product:async
28+
run: node --run bench:product:async
2929
- name: Benchmark (stream)
30-
run: npm run bench:product:stream
30+
run: node --run bench:product:stream
3131
- name: Benchmark (sync)
32-
run: npm run bench:product:sync
32+
run: node --run bench:product:sync
3333

3434
regress:
3535
name: Regress benchmark with options (${{ matrix.benchmark_options }})
@@ -55,14 +55,14 @@ jobs:
5555
node-version: 22
5656
- name: Install dependencies
5757
run: npm install
58-
- name: Prepare bundle
59-
run: npm run bundle
58+
- name: Build
59+
run: node --run build
6060
- name: Benchmark (async)
61-
run: npm run bench:regression:async
61+
run: node --run bench:regression:async
6262
- name: Benchmark (stream)
63-
run: npm run bench:regression:stream
63+
run: node --run bench:regression:stream
6464
- name: Benchmark (sync)
65-
run: npm run bench:regression:sync
65+
run: node --run bench:regression:sync
6666

6767
overhead:
6868
name: Overhead benchmark
@@ -79,11 +79,11 @@ jobs:
7979
node-version: 22
8080
- name: Install dependencies
8181
run: npm install
82-
- name: Prepare bundle
83-
run: npm run bundle
82+
- name: Build
83+
run: node --run build
8484
- name: Benchmark (async)
85-
run: npm run bench:overhead:async
85+
run: node --run bench:overhead:async
8686
- name: Benchmark (stream)
87-
run: npm run bench:overhead:stream
87+
run: node --run bench:overhead:stream
8888
- name: Benchmark (sync)
89-
run: npm run bench:overhead:sync
89+
run: node --run bench:overhead:sync

.github/workflows/main.yml

+2-2
Original file line numberDiff line numberDiff line change
@@ -35,8 +35,8 @@ jobs:
3535
run: npm install
3636
- name: Run Hygiene Checks
3737
run: npm run lint
38-
- name: Prepare bundle
39-
run: npm run bundle
38+
- name: Compile
39+
run: npm run compile
4040
- name: Run unit tests
4141
run: npm run test
4242
- name: Run e2e tests (sync)

package.json

+8-15
Original file line numberDiff line numberDiff line change
@@ -11,13 +11,13 @@
1111
"engines": {
1212
"node": ">=18.18.0"
1313
},
14-
"main": "build/index.js",
15-
"typings": "build/index.d.ts",
14+
"main": "out/index.js",
15+
"typings": "out/index.d.ts",
1616
"files": [
17-
"build",
18-
"!build/{benchmark,tests}",
19-
"!build/**/*.map",
20-
"!build/**/*.spec.*"
17+
"out",
18+
"!out/{benchmark,tests}",
19+
"!out/**/*.map",
20+
"!out/**/*.spec.*"
2121
],
2222
"keywords": [
2323
"glob",
@@ -35,7 +35,6 @@
3535
"@types/picomatch": "^3.0.1",
3636
"@types/sinon": "^17.0.3",
3737
"bencho": "^0.1.1",
38-
"esbuild": "^0.24.0",
3938
"eslint": "9.14.0",
4039
"eslint-config-mrmlnc": "^5.0.0",
4140
"execa": "^7.2.0",
@@ -57,7 +56,7 @@
5756
"micromatch": "^4.0.8"
5857
},
5958
"scripts": {
60-
"clean": "rimraf out build",
59+
"clean": "rimraf out",
6160
"lint": "eslint \"src/**/*.ts\" --cache",
6261
"compile": "tsc",
6362
"test": "mocha \"out/**/*.spec.js\" -s 0",
@@ -68,12 +67,6 @@
6867
"_build:compile": "npm run clean && npm run compile",
6968
"build": "npm run _build:compile && npm run lint && npm test",
7069
"watch": "npm run _build:compile -- -- --sourceMap --watch",
71-
"_bundle:dts": "tsc --emitDeclarationOnly --outDir ./build",
72-
"_bundle:ts": "esbuild --bundle ./src/index.ts --outfile=./build/index.js --platform=node --target=node18.18 --format=cjs",
73-
"_bundle:build": "npm run _bundle:dts && npm run _bundle:ts",
74-
"_bundle:test:replace": "cp ./build/index.js ./out",
75-
"_bundle:test": "npm run _bundle:test:replace",
76-
"bundle": "npm run _build:compile && npm run _bundle:build && npm run _bundle:test",
7770
"bench:async": "npm run bench:product:async && npm run bench:regression:async",
7871
"bench:stream": "npm run bench:product:stream && npm run bench:regression:stream",
7972
"bench:sync": "npm run bench:product:sync && npm run bench:regression:sync",
@@ -89,6 +82,6 @@
8982
"bench:overhead:async": "hereby bench:overhead:async",
9083
"bench:overhead:sync": "hereby bench:overhead:sync",
9184
"bench:overhead:stream": "hereby bench:overhead:stream",
92-
"prepublishOnly": "npm run bundle"
85+
"prepublishOnly": "npm run build"
9386
}
9487
}

0 commit comments

Comments
 (0)