fix(backend): replace hardcoded Redis DB numbers with SSOT env vars (#2806) (#2933)

fix(backend): replace hardcoded Redis DB numbers with SSOT env vars (#2806)

Author: mrveiss

autobot-infrastructure/shared/analysis/analytics_timeout_diagnostic.py

@@ -2,8 +2,9 @@
 """
 Fix Redis Timeout in Analytics Indexing
 
-This script addresses Redis timeout issues in the analytics database (DB 8)
-by implementing connection pooling, batch operations, and timeout protection.
+This script addresses Redis timeout issues in the analytics database (DB 11 per
+redis-databases.yaml SSOT — #2806) by implementing connection pooling, batch
+operations, and timeout protection.
 """
 
 import asyncio
@@ -23,6 +24,9 @@
 logging.basicConfig(level=logging.INFO)
 logger = logging.getLogger(__name__)
 
+# DB number from redis-databases.yaml SSOT (#2806): analytics = 11
+_DB_ANALYTICS = int(os.getenv("AUTOBOT_REDIS_DB_ANALYTICS", "11"))
+
 
 class AnalyticsRedisOptimizer:
     """Optimizes Redis operations for analytics database to prevent timeouts"""
@@ -44,7 +48,7 @@ async def initialize(self):
             self.connection_pool = redis.ConnectionPool(
                 host=redis_host,
                 port=redis_port,
-                db=8,
+                db=_DB_ANALYTICS,
                 max_connections=10,
                 socket_timeout=5,  # Reduced from default 30s
                 socket_connect_timeout=3,  # Reduced connection timeout

autobot-infrastructure/shared/scripts/analysis/analyze_redis_db0.py

@@ -7,6 +7,7 @@
 """
 
 import logging
+import os
 from collections import defaultdict
 from typing import Any, Dict, List, Tuple
 
@@ -15,6 +16,9 @@
 logging.basicConfig(level=logging.INFO)
 logger = logging.getLogger(__name__)
 
+# DB number from redis-databases.yaml SSOT (#2806): main = 0
+_DB_MAIN = int(os.getenv("AUTOBOT_REDIS_DB_MAIN", "0"))
+
 # Issue #338: Key pattern dispatch table for categorization
 KEY_PATTERN_PREFIXES = [
     ("llama_index/vector", "llama_index/vector"),
@@ -172,7 +176,7 @@ def analyze_redis_db0():
     """Analyze what's in Redis database 0"""
     # Issue #338: Refactored to use extracted helpers, reducing depth from 11 to 2
     try:
-        client = redis.Redis(host="localhost", port=6379, db=0, decode_responses=False)
+        client = redis.Redis(host="localhost", port=6379, db=_DB_MAIN, decode_responses=False)
 
         logger.info("=== ANALYZING REDIS DATABASE 0 ===")
 

autobot-infrastructure/shared/scripts/analysis/debug_redis_fields.py

@@ -7,18 +7,22 @@
 """
 
 import logging
+import os
 
 import redis
 
 logging.basicConfig(level=logging.INFO)
 logger = logging.getLogger(__name__)
 
+# DB number from redis-databases.yaml SSOT (#2806): knowledge = 1
+_DB_KNOWLEDGE = int(os.getenv("AUTOBOT_REDIS_DB_KNOWLEDGE", "1"))
+
 
 def debug_redis_vector_fields():
     """Debug what fields are available in Redis vector store"""
     try:
-        # Connect to Redis
-        client = redis.Redis(host="localhost", port=6379, db=2, decode_responses=True)
+        # Connect to Redis (knowledge DB — llama_index vectors live in DB 1)
+        client = redis.Redis(host="localhost", port=6379, db=_DB_KNOWLEDGE, decode_responses=True)
 
         # Get index info
         logger.info("Getting Redis FT.INFO for llama_index...")

autobot-infrastructure/shared/scripts/analysis/redis_final_analysis.py

@@ -9,6 +9,7 @@
 import asyncio
 import json
 import logging
+import os
 import sys
 from typing import Any, Dict, List, Tuple
 
@@ -21,6 +22,9 @@
 )
 logger = logging.getLogger(__name__)
 
+# DB number from redis-databases.yaml SSOT (#2806): knowledge = 1
+_DB_KNOWLEDGE = int(os.getenv("AUTOBOT_REDIS_DB_KNOWLEDGE", "1"))
+
 
 def _build_fix_llamaindex_recommendation(data_analysis, llamaindex_fixes):
     """Build recommendation for fixing LlamaIndex integration.
@@ -263,7 +267,7 @@ async def deep_analyze_existing_data(self) -> Dict[str, Any]:
             client = redis.Redis(
                 host=NetworkConstants.LOCALHOST_NAME,
                 port=NetworkConstants.REDIS_PORT,
-                db=2,
+                db=_DB_KNOWLEDGE,
                 decode_responses=True,
             )
 

autobot-infrastructure/shared/scripts/analysis/simple_redis_test.py

@@ -6,11 +6,16 @@
 Simple Redis hash test
 """
 
+import os
+
 import redis
 
+# DB number from redis-databases.yaml SSOT (#2806): knowledge = 1
+_DB_KNOWLEDGE = int(os.getenv("AUTOBOT_REDIS_DB_KNOWLEDGE", "1"))
+
 
 def simple_redis_test():
-    client = redis.Redis(host="localhost", port=6379, db=2, decode_responses=True)
+    client = redis.Redis(host="localhost", port=6379, db=_DB_KNOWLEDGE, decode_responses=True)
 
     # Get first key directly from FT.SEARCH
     result = client.execute_command("FT.SEARCH", "llama_index", "*", "LIMIT", "0", "1")

autobot-infrastructure/shared/scripts/analysis/test_data_layer_debug.py

@@ -12,13 +12,16 @@
 import traceback
 from pathlib import Path
 
-logger = logging.getLogger(__name__)
-
 import logging
 
 import aioredis
 import redis
 
+logger = logging.getLogger(__name__)
+
+# DB number from redis-databases.yaml SSOT (#2806): knowledge = 1
+_DB_KNOWLEDGE = int(os.getenv("AUTOBOT_REDIS_DB_KNOWLEDGE", "1"))
+
 
 def test_redis_basic():
     """Test basic Redis connectivity to all databases"""
@@ -61,12 +64,12 @@ def test_redis_basic():
 
 
 def test_vector_database():
-    """Test vector database in Redis DB 8"""
-    logger.info("\n=== VECTOR DATABASE TEST (Redis DB 8) ===")
+    """Test vector database in Redis knowledge DB (DB 1 per redis-databases.yaml SSOT)"""
+    logger.info("\n=== VECTOR DATABASE TEST (Redis knowledge DB) ===")
 
     try:
         client = redis.Redis(
-            host="localhost", port=6379, db=8, decode_responses=False, socket_timeout=2
+            host="localhost", port=6379, db=_DB_KNOWLEDGE, decode_responses=False, socket_timeout=2
         )
 
         # Check for LlamaIndex keys

autobot-infrastructure/shared/scripts/analysis/test_redis_comparison.py

@@ -9,11 +9,15 @@
 
 import asyncio
 import logging
+import os
 import sys
 import time
 
 from constants import ServiceURLs
 
+# DB number from redis-databases.yaml SSOT (#2806): knowledge = 1
+_DB_KNOWLEDGE = int(os.getenv("AUTOBOT_REDIS_DB_KNOWLEDGE", "1"))
+
 # Add the project root to the Python path
 sys.path.insert(0, "/home/kali/Desktop/AutoBot")
 
@@ -30,7 +34,7 @@ async def test_redis_connection():
     try:
         import redis
 
-        client = redis.Redis(host="localhost", port=6379, db=2, decode_responses=True)
+        client = redis.Redis(host="localhost", port=6379, db=_DB_KNOWLEDGE, decode_responses=True)
         client.ping()
         logger.info("✅ Redis connection successful")
 
@@ -288,7 +292,7 @@ async def analyze_existing_data():
     try:
         import redis
 
-        client = redis.Redis(host="localhost", port=6379, db=2, decode_responses=True)
+        client = redis.Redis(host="localhost", port=6379, db=_DB_KNOWLEDGE, decode_responses=True)
 
         # Get sample documents
         sample_keys = list(client.scan_iter(match="llama_index/vector*", count=5))

autobot-infrastructure/shared/scripts/analysis/test_redis_direct.py

@@ -7,17 +7,21 @@
 """
 
 import logging
+import os
 
 import redis
 
 logging.basicConfig(level=logging.INFO)
 logger = logging.getLogger(__name__)
 
+# DB number from redis-databases.yaml SSOT (#2806): knowledge = 1
+_DB_KNOWLEDGE = int(os.getenv("AUTOBOT_REDIS_DB_KNOWLEDGE", "1"))
+
 
 def test_redis_direct_access():
     """Test Redis direct access"""
     try:
-        client = redis.Redis(host="localhost", port=6379, db=2, decode_responses=True)
+        client = redis.Redis(host="localhost", port=6379, db=_DB_KNOWLEDGE, decode_responses=True)
 
         # Test FT.SEARCH with explicit RETURN
         logger.info("Testing FT.SEARCH with explicit RETURN...")

autobot-infrastructure/shared/scripts/fix_kb_dimensions.py

@@ -4,23 +4,26 @@
 """
 
 import asyncio
+import logging
 import os
 import sys
 
-logger = logging.getLogger(__name__)
-
-
 import redis
 
 # Add parent directory to path
 sys.path.insert(0, os.path.dirname(os.path.dirname(os.path.abspath(__file__))))
 
+logger = logging.getLogger(__name__)
+
+# DB number from redis-databases.yaml SSOT (#2806): knowledge = 1
+_DB_KNOWLEDGE = int(os.getenv("AUTOBOT_REDIS_DB_KNOWLEDGE", "1"))
+
 
 async def fix_dimensions():
     """Drop all llama_index traces and let it recreate properly."""
 
-    # Connect to Redis
-    r = redis.Redis(host="localhost", port=6379, db=0)
+    # Connect to Redis knowledge DB (llama_index lives in DB 1 per redis-databases.yaml SSOT, #2806)
+    r = redis.Redis(host="localhost", port=6379, db=_DB_KNOWLEDGE)
 
     logger.info("Cleaning up Redis...")
 

autobot-infrastructure/shared/scripts/fresh_kb_setup.py

@@ -8,19 +8,24 @@
 import os
 import sys
 
-logger = logging.getLogger(__name__)
+import redis  # noqa: redis — standalone script, see Issue #1086
 
 # Add parent directory to path
 sys.path.insert(0, os.path.dirname(os.path.dirname(os.path.abspath(__file__))))
 
+logger = logging.getLogger(__name__)
+
+# DB number from redis-databases.yaml SSOT (#2806): knowledge = 1
+_DB_KNOWLEDGE = int(os.getenv("AUTOBOT_REDIS_DB_KNOWLEDGE", "1"))
+
 
 def _clean_redis() -> None:
     """Clean all Redis databases and indexes.
 
     Helper for fresh_setup (Issue #825).
     """
     logger.info("\n1. Cleaning Redis...")
-    r = redis.Redis(host="localhost", port=6379, db=0)
+    r = redis.Redis(host="localhost", port=6379, db=_DB_KNOWLEDGE)
 
     try:
         indexes = r.execute_command("FT._LIST")
@@ -103,7 +108,7 @@ def _verify_index() -> None:
     Helper for fresh_setup (Issue #825).
     """
     logger.info("\n5. Checking created index...")
-    r = redis.Redis(host="localhost", port=6379, db=0)
+    r = redis.Redis(host="localhost", port=6379, db=_DB_KNOWLEDGE)
 
     indexes = r.execute_command("FT._LIST")
     logger.info(f"   Indexes: {indexes}")