Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Error in ExtensionCodec.ts? #241

Closed
ste-gr opened this issue Mar 15, 2024 · 1 comment · Fixed by #256
Closed

Error in ExtensionCodec.ts? #241

ste-gr opened this issue Mar 15, 2024 · 1 comment · Fixed by #256

Comments

@ste-gr
Copy link

ste-gr commented Mar 15, 2024

Hi,

I think there is a little error here:

msgpack-javascript/src/ExtensionCodec.ts

Line 57 in 1fc7622

const index = 1 + type;

Shouldn't it be const index = -1 - type;?

Greetings
Stefan
@gfx gfx mentioned this issue Feb 5, 2025
Merged
@gfx
Copy link
Member

gfx commented Feb 5, 2025 •
edited
Loading

Yes, it is! Thank you for the bug report.

Fixed in #256

@gfx gfx closed this as completed in #256 Feb 5, 2025
@gfx gfx closed this as completed in 3b62145 Feb 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix index of built-in encoders/decoders msgpack/msgpack-javascript
2 participants
@gfx @ste-gr