[Critical] Unable to Register

[jacobmoyle]

Attempted to register on Google Chrome Version 66.0.3359.181 (Official Build) (64-bit), was unable to successfully submit the form.

Refer to the following:

Please Note:

'<Password />' input fields were manually changed to type='text' for debugging purposes.

[mtvillwock]

@jacobmoyle
I just registered two new accounts without issue. However, when I tried to reproduce the error using your test data, it failed as indicated in your screenshot.

After checking the database on Heroku I found that you had already registered two accounts using the same email about a year ago.

User.where(email: "jacobmoyle@gmail.com")
  User Load (0.6ms)  SELECT "users".* FROM "users" WHERE "users"."email" = $1  [["email", "jacobmoyle@gmail.com"]]
  User Load (0.6ms)  SELECT "users".* FROM "users" WHERE "users"."email" = $1  [["email", "jacobmoyle@gmail.com"]]

=> #<ActiveRecord::Relation [

#<User id: 159, auth_token: "283fc471-8ac6-4995-ba1a-7e5b0a664c2d", name: "Jacob", created_at: "2017-05-27 19:16:06", updated_at: "2017-05-27 19:16:06", email: "jacobmoyle@gmail.com", password_hash: nil, location: nil, password_digest: "$2a$10$d6GWRtCkgDKjjqYfwPxHd.Onw3rV.GvtH0QiwpEJ2cI...">, 

#<User id: 160, auth_token: "7e40fc93-fd4b-402b-b9a9-f0814fd49066", name: "Jacob", created_at: "2017-05-27 19:16:06", updated_at: "2017-05-27 19:16:06", email: "jacobmoyle@gmail.com", password_hash: nil, location: nil, password_digest: "$2a$10$fHIci26nlyprKKMQ0UWWv.tDpQI11A9kKqvbGu4uKaG...">

]

Looks like there is a User model validation for email uniqueness which is causing this problem:
https://github.com/mtvillwock/JHO/blob/master/app/models/user.rb

Feel free to open a PR to fix the error handling in the UsersController so other users aren't confused by registration failing:
https://github.com/mtvillwock/JHO/blob/master/app/controllers/users_controller.rb
Extra points if you want to add password retrieval/reset routes!

[mtvillwock]

@jacobmoyle I've deleted your old accounts and registered your new one.

[jacobmoyle]

@mtvillwock Thanks boyo! My mistake.

Let's go the route you suggested... the Registration Form fails to provide helpful error handling.

A User should be:

• prompted to Login
• register a different email address.