add connection limits

Author: akuzia

src/Dplr/Dplr.php

@@ -41,6 +41,12 @@ class Dplr
      */
     protected $publicKey;
 
+    /** @var int */
+    protected $maxSSHAgentConnections;
+
+    /** @var int */
+    protected $maxConcurrency;
+
     /**
      * @var string
      */
@@ -50,11 +56,18 @@ class Dplr
 
     protected $state = self::STATE_INIT;
 
-    public function __construct(string $user, string $gosshaPath, string $publicKey = null)
-    {
+    public function __construct(
+        string $user,
+        string $gosshaPath,
+        string $publicKey = null,
+        int $maxSSHAgentConnections = 128,
+        int $maxConcurrency = 0
+    ) {
         $this->user = $user;
         $this->publicKey = $publicKey;
         $this->gosshaPath = $gosshaPath;
+        $this->maxSSHAgentConnections = $maxSSHAgentConnections;
+        $this->maxConcurrency = $maxConcurrency;
 
         $this->resetTasks();
     }
@@ -376,9 +389,22 @@ protected function runTasks(callable $callback = null): void
         $this->reports = [];
 
         if ($this->publicKey) {
-            $pl = sprintf('%s -l %s -i %s', $this->gosshaPath, $this->user, $this->publicKey);
+            $pl = sprintf(
+                '%s -l %s -i %s -m %d -c %d',
+                $this->gosshaPath,
+                $this->user,
+                $this->publicKey,
+                $this->maxConcurrency,
+                $this->maxSSHAgentConnections
+            );
         } else {
-            $pl = sprintf('%s -l %s', $this->gosshaPath, $this->user);
+            $pl = sprintf(
+                '%s -l %s -m %d -c %d',
+                $this->gosshaPath,
+                $this->user,
+                $this->maxConcurrency,
+                $this->maxSSHAgentConnections
+            );
         }
 
         $descriptorSpec = [

tests/Dplr/Tests/DplrTest.php

@@ -173,6 +173,41 @@ public function testMultiThread(): void
         }
     }
 
+    public function testLimitedConcurrency(): void
+    {
+        $d = new Dplr(self::USER, self::GOSSHA_PATH, self::SSH_KEY, 16, 1);
+        $d
+            ->addServer('remote_1', ['app', 'all'])
+            ->addServer('remote_2', ['app', 'all'])
+            ->addServer('remote_3', ['job', 'all'])
+        ;
+        $d->setDefaultTimeout(60);
+
+        $d->command('ls -a', 'all');
+        $this->assertTrue($d->hasTasks());
+
+        $output = '';
+        $d->run(function (string $s) use (&$output) {
+            $output .= $s;
+        });
+
+        $this->assertTrue($d->isSuccessful());
+        $this->assertFalse($d->hasTasks());
+        $this->assertEquals("CMD ls -a ...\n", $output);
+
+        $report = $d->getReport();
+        $this->assertEquals(3, $report['total']);
+        $this->assertEquals(3, $report['successful']);
+        $this->assertEquals(0, $report['failed']);
+
+        $this->assertCount(0, $d->getFailed());
+        $this->assertCount(3, $d->getReports());
+
+        foreach ($d->getReports() as $report) {
+            $this->assertTrue($report->isSuccessful());
+        }
+    }
+
     private static function getFixturesPath(): string
     {
         return realpath(__DIR__ . '/../Fixtures');