Skip to content

Commit f548bcb

Browse files
authored
fix(style): remove chinese comments in checkbox (element-plus#4189)
1 parent b4d54b6 commit f548bcb

File tree

2 files changed

+9
-1
lines changed

2 files changed

+9
-1
lines changed

DEV_FAQ.md

+8
Original file line numberDiff line numberDiff line change
@@ -25,3 +25,11 @@ pnpm link --global element-plus
2525
```
2626

2727
> More info see [pnpm link](https://pnpm.io/cli/link).
28+
29+
## Theme
30+
31+
We should not write Chinese comments in scss files.
32+
33+
It will generate warning `@charset "UTF-8";` in the header of css file when built with vite.
34+
35+
> More info see [#3219](https://github.com/element-plus/element-plus/issues/3219).

packages/theme-chalk/src/checkbox.scss

+1-1
Original file line numberDiff line numberDiff line change
@@ -180,7 +180,7 @@ $checkbox-bordered-input-width: map.merge(
180180
}
181181
}
182182
@include when(focus) {
183-
/*focus时 视觉上区分*/
183+
// Visually distinguish when focus
184184
.#{$namespace}-checkbox__inner {
185185
border-color: var(--el-checkbox-input-border-color-hover);
186186
}

0 commit comments

Comments
 (0)