Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pro: Update Payment Intent Description #8565

Open
garethrees opened this issue Feb 5, 2025 · 1 comment · May be fixed by #8582
Open

Pro: Update Payment Intent Description #8565

garethrees opened this issue Feb 5, 2025 · 1 comment · May be fixed by #8582
Assignees
Labels
f:payments improvement Improves existing functionality (UI tweaks, refactoring, performance, etc) x:uk

Comments

@garethrees
Copy link
Member

garethrees commented Feb 5, 2025

A while ago we started updating the Stripe Charge description so that it was easy to identify WhatDoTheyKnow Pro charges in CSV exports for finance reconciliation (#4435). I've verified that this charge update appears to be correctly happening by looking at the event logs for a recent payment.

Image
…scroll down the json panel on the right and see the description value correctly updated…
Image

Currently we do not see this description in the CSV export available to us, but we do for other services. For WhatDoTheyKnow Pro, we just see "Invoice [INVOICE_ID]".

Image

@jaquarone and I think we've narrowed this down to needing to update the payment intent description as well as the charge description.

Here's a TWFY payment intent record – you can see "TheyWorkForYou" in the description in the sidebar.

Image

A WDTK payment intent record is showing the default Invoice ID, which is what we're seeing in the CSV export:

Image


There's also some possibly useful historical context in https://github.com/mysociety/alaveteli-professional/issues/602.

@garethrees garethrees added x:uk improvement Improves existing functionality (UI tweaks, refactoring, performance, etc) f:payments labels Feb 5, 2025
@dracos
Copy link
Member

dracos commented Feb 13, 2025

That's not the right MapIt reference, that's for a single bulk payment; the equivalent you're looking for, for when we get a successful invoice payment is https://github.com/mysociety/mapit.mysociety.org/blob/master/subscriptions/views.py#L466-L472

@gbp gbp self-assigned this Feb 13, 2025
gbp added a commit that referenced this issue Feb 13, 2025
After successful payments ensure the payment intent description is
correct. This helps accounting procedures.

Fixes #8565
gbp added a commit that referenced this issue Feb 13, 2025
After successful payments ensure the payment intent description is
correct. This helps accounting procedures.

Fixes #8565
@gbp gbp linked a pull request Feb 13, 2025 that will close this issue
gbp added a commit that referenced this issue Feb 13, 2025
After successful payments ensure the payment intent description is
correct. This helps accounting procedures.

Fixes #8565
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
f:payments improvement Improves existing functionality (UI tweaks, refactoring, performance, etc) x:uk
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants