Skip to content

Commit 25e79ef

Browse files
committed
All NDB read results (including those containing BLOB and TEXT columns)
are now ValueObjects.
1 parent e6a4a0e commit 25e79ef

File tree

2 files changed

+1
-10
lines changed

2 files changed

+1
-10
lines changed

Adapter/impl/ndb/NdbOperation.js

+1-5
Original file line numberDiff line numberDiff line change
@@ -732,11 +732,7 @@ function buildOperationResult(transactionHandler, op, op_ndb_error, execMode) {
732732
}
733733

734734
if(op.result.success && op.opcode === opcodes.OP_READ) {
735-
// if(op.tableHandler.numberOfLobColumns) {
736-
// readResultRow(op); // Objects with BLOBs get plain JS Objects
737-
// } else {
738-
buildValueObject(op); // Objects without BLOBS get ValueObjects
739-
// }
735+
buildValueObject(op);
740736
}
741737
}
742738
if(udebug.is_detail()) udebug.log("buildOperationResult finished:", op.result);

Adapter/impl/ndb/src/NdbTypeEncoders.cpp

-5
Original file line numberDiff line numberDiff line change
@@ -1177,11 +1177,6 @@ Handle<Value> CharWriter(const NdbDictionary::Column * col,
11771177
return writerOK;
11781178
}
11791179

1180-
// TODO: In both CHAR and VARCHAR readers,
1181-
// in the case where the result is not a ValueObject, but the string is
1182-
// externalized from an ASCII or UTF16LE buffer, verify that the buffer
1183-
// contents will remain valid for the whole lifetime of the string.
1184-
11851180
// Templated encoder for Varchar and LongVarchar
11861181
template<typename LENGTHTYPE>
11871182
Handle<Value> varcharReader(const NdbDictionary::Column *col,

0 commit comments

Comments
 (0)