Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Browser code missing named AbortController export #32

Open
wemeetagain opened this issue Jun 18, 2021 · 0 comments
Open

Browser code missing named AbortController export #32

wemeetagain opened this issue Jun 18, 2021 · 0 comments

Comments

@wemeetagain
Copy link

browser.js is missing the AbortController named export.
The AbortController named export exists in src/abort-controller.ts (and browser.mjs), however, is missing in browser.js.
This results in an inconsistency. Code that successfully runs in nodejs throws an unexpected error when run in the browser.
Ex:

import {AbortController} from "abort-controller';
...

Typescript public interface includes an exported AbortController member, and popular convention is to use a named export if available (See this eslint-plugin-export rule). Thus, this issue will very likely affect direct consumers of this library, and worse, consumers further downstream, if consumers don't explicitly have browser tests!

This issue is for documentation purposes as several PRs implementing a fix are already open.
See: #22 and #29

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant