Skip to content

Commit 1ff13f5

Browse files
authored
fix: Hide the xxx_sink variants from the public API (#123)
## Description These functions are internal and have no business being in the public API, I think ## Breaking Changes Removes - api::remote::Remote::fetch_sink - api::remote::Remote::execute_push_sink - api::remote::Remote::execute_get_sink ## Notes & open questions Note: maybe we need to expose them at some point, but currently I don't see the need, and in any case the Sink trait is not exposed, so nobody can use them anyway at this time! ## Change checklist - [ ] Self-review. - [ ] Documentation updates following the [style guide](https://rust-lang.github.io/rfcs/1574-more-api-documentation-conventions.html#appendix-a-full-conventions-text), if relevant. - [ ] Tests if relevant. - [ ] All breaking changes documented.
1 parent 8eb5733 commit 1ff13f5

File tree

1 file changed

+3
-3
lines changed

1 file changed

+3
-3
lines changed

src/api/remote.rs

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -499,7 +499,7 @@ impl Remote {
499499
/// is the aggregated number of downloaded payload bytes in the request.
500500
///
501501
/// This will return the stats of the download.
502-
pub async fn fetch_sink(
502+
pub(crate) async fn fetch_sink(
503503
&self,
504504
mut conn: impl GetConnection,
505505
content: impl Into<HashAndFormat>,
@@ -573,7 +573,7 @@ impl Remote {
573573
/// Push the given blob or hash sequence to a remote node.
574574
///
575575
/// Note that many nodes will reject push requests. Also, this is an experimental feature for now.
576-
pub async fn execute_push_sink(
576+
pub(crate) async fn execute_push_sink(
577577
&self,
578578
conn: Connection,
579579
request: PushRequest,
@@ -654,7 +654,7 @@ impl Remote {
654654
/// This will download the data again even if the data is locally present.
655655
///
656656
/// This will return the stats of the download.
657-
pub async fn execute_get_sink(
657+
pub(crate) async fn execute_get_sink(
658658
&self,
659659
conn: Connection,
660660
request: GetRequest,

0 commit comments

Comments
 (0)