-
Notifications
You must be signed in to change notification settings - Fork 14
docs: Expiring tags example #89
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
rklaehn
wants to merge
8
commits into
main
Choose a base branch
from
expiring-tags-example
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
+187
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Documentation for this PR has been generated and is available at: https://n0-computer.github.io/iroh-blobs/pr/89/docs/iroh_blobs/ Last updated: 2025-07-25T09:43:04Z |
rklaehn
commented
Jul 25, 2025
@@ -4,7 +4,8 @@ use std::{ | |||
time::Duration, | |||
}; | |||
|
|||
use super::{gc::GcConfig, meta::raw_outboard_size, temp_name}; | |||
pub use super::gc::GcConfig; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
missing export!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Example how you would implement expiring tags efficiently
Breaking Changes
None
Notes & open questions
This is now in-process, unlike the previous example that used rpc to a running old iroh node.
I have 2 modes for deletion, one by one and bulk. Not sure, should I just keep bulk?
Change checklist