bin/git-review: Fix save

Author: n1amr

bin/git-review

@@ -95,7 +95,7 @@ auto_calculate_args() {
     checkpoint_file="$git_dir/review/checkpoints/${pr_branch//\//%}"
 
     if [[ -z "$from_checkpoint" ]] && [[ -f "$checkpoint_file" ]]; then
-        from_checkpoint="$(cat "$checkpoint_file" | tail -n 1)"
+        from_checkpoint="$(get_last_checkpoint)"
     fi
 
     if [[ "$local_branch" == 'true' ]]; then
@@ -146,16 +146,20 @@ exec_reset_checkpoint() {
 }
 
 exec_save_checkpoint() {
-    if ! has_changes; then
-        info 'No changes to save.'
-        exit 0
+    if has_changes; then
+        git status
+
+        git commit -m "Reviewed (from checkpoint $from_checkpoint)"
     fi
 
-    git status
+    new_checkpoint="$(git rev-parse --verify HEAD)"
+    last_checkpoint="$(get_last_checkpoint)"
 
-    git commit -m "Reviewed (from checkpoint $from_checkpoint)"
+    if [[ "$new_checkpoint" == "$last_checkpoint" ]]; then
+        info 'No changes to save.'
+        exit 0
+    fi
 
-    new_checkpoint="$(git rev-parse --verify HEAD)"
     mkdir -p "$(dirname "$checkpoint_file")"
     echo "$new_checkpoint" >> "$checkpoint_file"
     info "Saved checkpoint '$new_checkpoint' to '$checkpoint_file'."
@@ -226,4 +230,12 @@ exec_update() {
     exit 0
 }
 
+get_last_checkpoint() {
+    if ! [[ -f "$checkpoint_file" ]]; then
+        fail 'No checkpoint file.'
+    fi
+
+    cat "$checkpoint_file" | tail -n 1
+}
+
 main "$@"

config/vscode/User/settings.json

@@ -285,6 +285,7 @@
     "cmake",
     "cyclomatic",
     "datefmt",
+    "descendency",
     "dotfiles",
     "dtype",
     "eventhub",